commit | 4dac028c014cf7da7a7bbb39885d2f5a3823d0bf | [log] [tgz] |
---|---|---|
author | Wade Guthrie <wdg@chromium.org> | Wed Jun 05 17:30:29 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Wed Jun 19 12:22:56 2013 -0700 |
tree | f971f0c98a30730021f52d9f3b67ee75f56cac74 | |
parent | 3e22e73be8b7c4aec2f64b9ab2ab135d018c3834 [diff] |
shill: Removes some anachronistic TODOs, adds data to a test. This CL does a few, tiny, unrelated things (there're probably more lines in the commit message). Many of the TODOs dealt with not instantiating netlink attributes for messages coming from the kernel after we have the messages instantiate their own attributes. The decision, since then, has been to let the user-bound messages re-create any attributes that have already been created by the message constructor. There's another TODO that was fixed by an earlier CL that converted a test to using mock_netlink_manager rather than netlink_manager. BUG=None TEST=unittest Change-Id: I0ebff4f652b2ce83bcb2ba8b08f99d7899fce4d7 Reviewed-on: https://gerrit.chromium.org/gerrit/57800 Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> Commit-Queue: Wade Guthrie <wdg@chromium.org>