shill: vpn: Remove support for obsolete Service.Provider.Name.

Chrome doesn't set this property anymore -- it sets Service.Name
instead.

BUG=chromium:221577
TEST=unit tests; tested on device by connecting to a new VPN service
through the UI as well as through connect-vpn, inspectings logs and
profile, checked service name.

Change-Id: I4b9d1a0c1e1619a6c1c71232829780099eb4507a
Reviewed-on: https://gerrit.chromium.org/gerrit/47121
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Queue: Darin Petkov <petkov@chromium.org>
diff --git a/manager_unittest.cc b/manager_unittest.cc
index d14fd1a..524ddd4 100644
--- a/manager_unittest.cc
+++ b/manager_unittest.cc
@@ -1480,7 +1480,7 @@
   args.SetString(flimflam::kTypeProperty, flimflam::kTypeVPN);
   args.SetString(flimflam::kProviderTypeProperty, flimflam::kProviderOpenVpn);
   args.SetString(flimflam::kProviderHostProperty, "10.8.0.1");
-  args.SetString(flimflam::kProviderNameProperty, "vpn-name");
+  args.SetString(flimflam::kNameProperty, "vpn-name");
   scoped_refptr<MockProfile> profile(
       new StrictMock<MockProfile>(
           control_interface(), metrics(), manager(), ""));