| commit | 4fef2499de05dfdeb1334afae92dee3ae1b3604f | [log] [tgz] |
|---|---|---|
| author | mukesh agrawal <quiche@chromium.org> | Thu Aug 01 16:03:59 2013 -0700 |
| committer | ChromeBot <chrome-bot@google.com> | Tue Aug 06 10:44:26 2013 -0700 |
| tree | 2775d5e1b73490fa6c14c7c28065a0ba8a717ea8 | |
| parent | 12533ad51178dd83d1899ab738c9f7aeb564fe03 [diff] |
shill: more unit test changes for ppp dongle support This time, we focus on PPPDevice. We add a couple more constraints to the ParseIPConfiguration test. While there: we modify the interface for ParseIPConfiguration. Previously, the target IPConfig::Properties object was supplied as an out parameter. Now, the method returns an IPConfig::Properties object instead. This was motivated by the new part of the ParseIPConfiguration test, where the behavior depended on whether or not I passed ParseIPConfiguration a fresh IPConfig::Properties object. The new interface avoids that gotcha. BUG=chromium:246826 TEST=unit tests (old+new) Change-Id: Icf6dbd0e31623a228779439b23a42970d9b85042 Reviewed-on: https://gerrit.chromium.org/gerrit/64294 Reviewed-by: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org>