commit 51a4f9348811dd786e632e98fd464411f54590ba
author Prathmesh Prabhu <pprabhu@chromium.org> Wed Aug 13 13:13:27 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Sat Aug 16 05:27:20 2014 +0000
tree ce1a82f143f21bc70d0d248b1639de215b56e08d
parent e9460c3ee4e4d9357491efffca4011beeb64bcaa

shill: dbus adaptors should leave an error trace.

Shill does not currently uniformly log error messages it returns on its DBus
interface. This is very useful as a default test logging behaviour to debug
failures.

BUG=chromium:403486
TEST=unittests.

Change-Id: I3f66df7d19491962e2c2f96ff2b691836fecebcf
Reviewed-on: https://chromium-review.googlesource.com/212356
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>

dbus_adaptor.cc

diff --git a/dbus_adaptor.cc b/dbus_adaptor.cc
index c22929c..739eb1f 100644
--- a/dbus_adaptor.cc
+++ b/dbus_adaptor.cc
@@ -494,6 +494,8 @@
                                     const DBus::Error &error) {
   Continuation *cont = find_continuation(tag);
   CHECK(cont) << "Failed to find continuation.";
+  SLOG(DBus, 1) << "Returning error: (" << error.name() << ": "
+                << error.message() << ")";
   return_error(cont, error);
 }