| commit | 64b0fe518af774534e554f5c55369824bbd66a4e | [log] [tgz] |
|---|---|---|
| author | Thieu Le <thieule@chromium.org> | Wed Aug 08 14:57:36 2012 -0700 |
| committer | Gerrit <chrome-bot@google.com> | Thu Aug 09 13:34:22 2012 -0700 |
| tree | da0f3e6591f1214c016e55a413bb29f8d8019dc6 | |
| parent | 784566d196431b97657760cab5d805a020b2712a [diff] |
shill: Change cellular callback bindings to weak pointers. Change to using weak pointers in DBus callback bindings so that we do not hold a reference count out on the object while calling into modem manager. This becomes a problem if an async DBus call is in progress and we release the proxy. The callback does not get executed which leaves a dangling reference count and keeps the object alive. This stale DBus object prevents us from properly registering the new DBus object since the two paths are the same. BUG=chromium-os:31636 TEST=Unit tests, network_3GSuspendResume Change-Id: I252f9e28978b5426509bfafdd66adbfd8b289936 Reviewed-on: https://gerrit.chromium.org/gerrit/29667 Reviewed-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Tested-by: Thieu Le <thieule@chromium.org> Commit-Ready: Thieu Le <thieule@chromium.org>