commit 6bb9e7c2c068fc15333babea8e66f02332683e33
author mukesh agrawal <quiche@chromium.org> Mon Jan 30 14:57:54 2012 -0800
committer Gerrit <chrome-bot@google.com> Wed Feb 08 20:14:42 2012 -0800
tree 6794af2dc82d91396e429d9efac77340d139a398
parent 8abd2f67616c3d138346781a49a40d4ae2bc7019

shill: rename DispatchOnType to SetProperty

I think this name is clearer. While the function does
have to dispatch based on type, what the caller is trying
to do is to set a property.

BUG=None
TEST=unit tests
Change-Id: I7eedd5a74de7f465310d07271e61cff320645fd8
Reviewed-on: https://gerrit.chromium.org/gerrit/15538
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: mukesh agrawal <quiche@chromium.org>

dhcp_config_unittest.cc

diff --git a/dhcp_config_unittest.cc b/dhcp_config_unittest.cc
index 0a19e54..e5817a7 100644
--- a/dhcp_config_unittest.cc
+++ b/dhcp_config_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -374,17 +374,17 @@
   EXPECT_CALL(*glib(), SpawnClosePID(kPID)).Times(1);  // Invoked by destructor.
 }
 
-TEST_F(DHCPConfigTest, Dispatch) {
-  EXPECT_TRUE(DBusAdaptor::DispatchOnType(config_->mutable_store(),
-                                          flimflam::kMtuProperty,
-                                          PropertyStoreTest::kInt32V,
-                                          NULL));
+TEST_F(DHCPConfigTest, SetProperty) {
+  EXPECT_TRUE(DBusAdaptor::SetProperty(config_->mutable_store(),
+                                       flimflam::kMtuProperty,
+                                       PropertyStoreTest::kInt32V,
+                                       NULL));
   ::DBus::Error error;
   // Ensure that an attempt to write a R/O property returns InvalidArgs error.
-  EXPECT_FALSE(DBusAdaptor::DispatchOnType(config_->mutable_store(),
-                                           flimflam::kAddressProperty,
-                                           PropertyStoreTest::kStringV,
-                                           &error));
+  EXPECT_FALSE(DBusAdaptor::SetProperty(config_->mutable_store(),
+                                        flimflam::kAddressProperty,
+                                        PropertyStoreTest::kStringV,
+                                        &error));
   EXPECT_EQ(invalid_args(), error.name());
 }