commit 6bb9e7c2c068fc15333babea8e66f02332683e33
author mukesh agrawal <quiche@chromium.org> Mon Jan 30 14:57:54 2012 -0800
committer Gerrit <chrome-bot@google.com> Wed Feb 08 20:14:42 2012 -0800
tree 6794af2dc82d91396e429d9efac77340d139a398
parent 8abd2f67616c3d138346781a49a40d4ae2bc7019

shill: rename DispatchOnType to SetProperty

I think this name is clearer. While the function does
have to dispatch based on type, what the caller is trying
to do is to set a property.

BUG=None
TEST=unit tests
Change-Id: I7eedd5a74de7f465310d07271e61cff320645fd8
Reviewed-on: https://gerrit.chromium.org/gerrit/15538
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: mukesh agrawal <quiche@chromium.org>

service_unittest.cc

diff --git a/service_unittest.cc b/service_unittest.cc
index 24cd06c..bb43eaa 100644
--- a/service_unittest.cc
+++ b/service_unittest.cc
@@ -115,52 +115,52 @@
   }
 }
 
-TEST_F(ServiceTest, Dispatch) {
+TEST_F(ServiceTest, SetProperty) {
   {
     ::DBus::Error error;
-    EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                            flimflam::kSaveCredentialsProperty,
-                                            PropertyStoreTest::kBoolV,
-                                            &error));
+    EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                         flimflam::kSaveCredentialsProperty,
+                                         PropertyStoreTest::kBoolV,
+                                         &error));
   }
   {
     ::DBus::Error error;
-    EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                            flimflam::kPriorityProperty,
-                                            PropertyStoreTest::kInt32V,
-                                            &error));
+    EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                         flimflam::kPriorityProperty,
+                                         PropertyStoreTest::kInt32V,
+                                         &error));
   }
   {
     ::DBus::Error error;
-    EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                            flimflam::kEAPEAPProperty,
-                                            PropertyStoreTest::kStringV,
-                                            &error));
+    EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                         flimflam::kEAPEAPProperty,
+                                         PropertyStoreTest::kStringV,
+                                         &error));
   }
   // Ensure that an attempt to write a R/O property returns InvalidArgs error.
   {
     ::DBus::Error error;
-    EXPECT_FALSE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                             flimflam::kFavoriteProperty,
-                                             PropertyStoreTest::kBoolV,
-                                             &error));
+    EXPECT_FALSE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                          flimflam::kFavoriteProperty,
+                                          PropertyStoreTest::kBoolV,
+                                          &error));
     EXPECT_EQ(invalid_args(), error.name());
   }
   {
     ::DBus::Error error;
     service_->set_favorite(true);
-    EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                            flimflam::kAutoConnectProperty,
-                                            PropertyStoreTest::kBoolV,
-                                            &error));
+    EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                         flimflam::kAutoConnectProperty,
+                                         PropertyStoreTest::kBoolV,
+                                         &error));
   }
   {
     ::DBus::Error error;
     service_->set_favorite(false);
-    EXPECT_FALSE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
-                                             flimflam::kAutoConnectProperty,
-                                             PropertyStoreTest::kBoolV,
-                                             &error));
+    EXPECT_FALSE(DBusAdaptor::SetProperty(service_->mutable_store(),
+                                          flimflam::kAutoConnectProperty,
+                                          PropertyStoreTest::kBoolV,
+                                          &error));
     EXPECT_EQ(invalid_args(), error.name());
   }
 }