shill: Naming and lint cleanup pass
Reduce some double-speak in IPAddress constants. Do a cursory
glint pass and clean up a few no-brainer issues.
BUG=None
TEST=Re-run unit tests
Change-Id: I063cd72111bd1f6321f81c6c6591b9f51d87434d
Reviewed-on: http://gerrit.chromium.org/gerrit/7181
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
diff --git a/rtnl_handler.cc b/rtnl_handler.cc
index dc48c71..b2bbac4 100644
--- a/rtnl_handler.cc
+++ b/rtnl_handler.cc
@@ -93,7 +93,7 @@
if (!sockets_)
return;
- rtnl_handler_.reset(NULL);
+ rtnl_handler_.reset();
sockets_->Close(rtnl_socket_);
in_request_ = false;
sockets_ = NULL;
@@ -199,7 +199,7 @@
0,
0,
0,
- IPAddress::kAddressFamilyUnknown);
+ IPAddress::kFamilyUnknown);
CHECK(SendMessage(&msg));
last_dump_sequence_ = msg.seq();
@@ -216,10 +216,13 @@
if (!NLMSG_OK(hdr, static_cast<unsigned int>(end - buf)))
break;
+ VLOG(3) << __func__ << ": received payload (" << end - buf << ")";
+
RTNLMessage msg;
if (!msg.Decode(ByteString(reinterpret_cast<unsigned char *>(hdr),
hdr->nlmsg_len))) {
-
+ VLOG(3) << __func__ << ": rtnl packet type "
+ << hdr->nlmsg_type << " length " << hdr->nlmsg_len;
switch (hdr->nlmsg_type) {
case NLMSG_NOOP:
case NLMSG_OVERRUN: