commit | 763df8647ed22caf6a160cedc3bb6f915a3a53dc | [log] [tgz] |
---|---|---|
author | Arman Uguray <armansito@chromium.org> | Tue Jul 02 12:49:10 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Tue Jul 02 16:31:08 2013 -0700 |
tree | cdd0eab0aabe6c17eb8eee7feffd95980805ee22 | |
parent | a63f5215c3d7fd8120c75de9dca299e0d4360bc5 [diff] |
shill: cellular: Properly translate errors from ModemManager. The existing code that handled mapping some ModemManager errors to shill API errors did not conform to the ModemManager1 API. This CL adds a new static method to CellularError to handle ModemManager1 errors separately. BUG=chromium:248835 TEST=1. Build and run unit tests. 2. Start the pseudomodem in locked mode (after stopping ModemManager and cromo). 3. Use dbus-send or python to interact with the shill Device API directly. Use methods such as EnterPin with incorrect values and verify that the D-Bus error returned by shill are meaningful (e.g. entering an incorrect pin should return an error with the name 'org.chromium.flimflam.Error.IncorrectPin'). Change-Id: I0672595cf1db39491e7c946a3527ced80cff8ceb Reviewed-on: https://gerrit.chromium.org/gerrit/60796 Reviewed-by: Thieu Le <thieule@chromium.org> Commit-Queue: Arman Uguray <armansito@chromium.org> Tested-by: Arman Uguray <armansito@chromium.org>