commit 7ac610b7edc059fbcc378cdac9ca235975470563
author Wade Guthrie <wdg@chromium.org> Tue Oct 01 17:48:14 2013 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Oct 10 18:06:33 2013 +0000
tree 7b1a1d15573621360ba9933f5bade3b9bf6478f9
parent 13804a1acd238a3c7ba8f4f44db96a97fa04fbda

shill: Converts many metrics calls to take references, not pointers.

I noticed some code that takes pointers that could crash if given a NULL
pointer.  While I fixed that, I decided that I'd modify other methods
that take pointers but where NULL is not a valid parameter.  This seems
consistent with Google style.

BUG=None.
TEST=unittest

Change-Id: I368fd66e1aa9d3ff81ec0fc2902af4721d6c1dde
Reviewed-on: https://chromium-review.googlesource.com/171510
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Wade Guthrie <wdg@chromium.org>
Tested-by: Wade Guthrie <wdg@chromium.org>
Commit-Queue: Wade Guthrie <wdg@chromium.org>

metrics.h

diff --git a/metrics.h b/metrics.h
index daa1ba6..4091582 100644
--- a/metrics.h
+++ b/metrics.h
@@ -450,16 +450,16 @@
 
   // Registers a service with this object so it can use the timers to track
   // state transition metrics.
-  void RegisterService(const Service *service);
+  void RegisterService(const Service &service);
 
   // Deregisters the service from this class.  All state transition timers
   // will be removed.
-  void DeregisterService(const Service *service);
+  void DeregisterService(const Service &service);
 
   // Tracks the time it takes |service| to go from |start_state| to
   // |stop_state|.  When |stop_state| is reached, the time is sent to UMA.
   virtual void AddServiceStateTransitionTimer(
-      const Service *service, const std::string &histogram_name,
+      const Service &service, const std::string &histogram_name,
       Service::ConnectState start_state, Service::ConnectState stop_state);
 
   // Specializes |metric_name| for the specified |technology_id|.
@@ -471,11 +471,11 @@
   virtual void NotifyDefaultServiceChanged(const Service *service);
 
   // Notifies this object that |service| state has changed.
-  virtual void NotifyServiceStateChanged(const Service *service,
+  virtual void NotifyServiceStateChanged(const Service &service,
                                          Service::ConnectState new_state);
 
   // Notifies this object that |service| has been disconnected.
-  void NotifyServiceDisconnect(const Service *service);
+  void NotifyServiceDisconnect(const Service &service);
 
   // Notifies this object of power at disconnect.
   void NotifySignalAtDisconnect(const Service &service,
@@ -645,10 +645,10 @@
   static const uint16 kWiFiFrequency5745;
   static const uint16 kWiFiFrequency5825;
 
-  void InitializeCommonServiceMetrics(const Service *service);
+  void InitializeCommonServiceMetrics(const Service &service);
   void UpdateServiceStateTransitionMetrics(ServiceMetrics *service_metrics,
                                            Service::ConnectState new_state);
-  void SendServiceFailure(const Service *service);
+  void SendServiceFailure(const Service &service);
 
   DeviceMetrics *GetDeviceMetrics(int interface_index) const;
   void AutoConnectMetricsReset(DeviceMetrics *device_metrics);