commit | cbfb34e699532f62eb5b381d0ea3a15d39e00b7c | [log] [tgz] |
---|---|---|
author | mukesh agrawal <quiche@chromium.org> | Wed Apr 17 19:33:25 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Wed Apr 24 12:05:05 2013 -0700 |
tree | 6c7a1779a22d0a6aa09ce099818a2e5233749358 | |
parent | 0b1ebf11b58cbb23abc0d5b1c914dfadcbae7669 [diff] |
shill: Emit more property change notifications for Services. Add property change notifications for all the Service properties that Chrome currently pays attention to. Also add unit tests for these property change notifications. While there: - add some more tips to TESTING - update service-api documentation for AutoConnect (it is settable for non-favorite services, and has been for some time) - update some ServiceTests to no longer set_favorite before changing AutoConnect (set_favorite is no longer necessary, as noted above) - clarify service-api documentation for Device property - make the security_ field of WiFiService const (it is only set in the ctor, and designating it const makes it obvious why there's no property change for it) - fix bug where VPNService would change the Favorite property, but not signal the change BUG=chromium:230329 TEST=new unit tests Change-Id: Ia387b1ab90fa80fd218cd69e0fd8126ff4c5a2ae Reviewed-on: https://gerrit.chromium.org/gerrit/48459 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org>