commit | 303f65324659b1bbe5ad0b8d2664d8892169eae8 | [log] [tgz] |
---|---|---|
author | Prathmesh Prabhu <pprabhu@chromium.org> | Fri Aug 29 20:17:16 2014 -0700 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Wed Sep 03 19:30:37 2014 +0000 |
tree | 05fc3d6f65f8369e3b9b60b808fd7085da91aa98 | |
parent | 16f98260d5f69c2c4b5a7284756c6e7b8a19239a [diff] |
shill: cellular: mock proxy objects fail DBus calls synchronously by default. This CL introduces a new mock action to pick out the (shill::Error *) argument passed to mock DBus proxy objects, and set it to a particular error type. This mock action is used to set default behaviour of all cellular related mock proxies to fail DBus method calls synchronously. This is the only sensible default behaviour because a successful DBus calls requires a continuation in the form of a callback to report result. Before this CL, the error argument was left untouched by default, i.e., the error returned was Error::kSuccess. This behaviour has now changed to return Error::kOperatorFailed. BUG=chromium:409386 TEST=Run shill unittests. CQ-DEPEND=CL:215791 Change-Id: I9f00f9fa4b70936ed1ff697a8e8524f389882433 Reviewed-on: https://chromium-review.googlesource.com/215790 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>