commit | 1c1dd351729e4d60ab24fdbfaf4fc439f14876c2 | [log] [tgz] |
---|---|---|
author | mukesh agrawal <quiche@chromium.org> | Wed May 08 15:58:34 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Wed May 08 18:41:15 2013 -0700 |
tree | 378e0d93199266d1c9c471c9f53ff92fbe038e7d | |
parent | 3fd54bd6e0c9bb81f4324cf96b53d35e7f134813 [diff] |
shill: fix crash in IPConfig::UpdateProperties If UpdateProperties reports failure to |update_callback_|, the device owning the IPConfig object may drop its reference to the IPConfig. We'll then crash, when we try to EmitChanges. Avoid the crash by having UpdateProperties hold a reference to the IPConfig object for the duration of the method call. BUG=chromium:237576 TEST=new unit test Change-Id: Ia3ce1a4729429ec75d4aab6b4c84b67f573d9187 Reviewed-on: https://gerrit.chromium.org/gerrit/50509 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org>