commit | 836a937c9f3a2397e69a2edc0b4bc15ec2401936 | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Wed Apr 23 19:57:15 2014 -0700 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Thu Apr 24 21:58:02 2014 +0000 |
tree | 7fe781a6362d3991857b084a745757af7bd93383 | |
parent | 923226aeb152d92fb21036ac88580686255b6d3d [diff] |
shill: Service: Remove duplicate OnPropertyChanged calls This CL unravels a small mystery about the OnPropertyChanged calls in shill Service objects. In the very elegantly written CL https://gerrit.chromium.org/gerrit/49733, the property store invokes a callback in its owner (in this case the Service) to notify it when properties have been changed in a non-trivial manner, filtering out no-op changes. However, this CL failed to remove all previous methods for doing so, e.g., https://gerrit.chromium.org/gerrit/37304. This caused Service::Configure calls to invoke OnPropertyChanged twice for non-trivial changes and once for trivial calls. This CL cleans up the redundant calls and adds a unit test that mocks the OnPropertyChanged method in the ServiceUnderTest to assure that Configure calls work correctly in this respect. BUG=chromium:364298 TEST=New unit test Change-Id: I0dbb515ef640f0f90a25398741d80c039678f6f7 Reviewed-on: https://chromium-review.googlesource.com/196730 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>