commit | 87fc23e2f38def031f702780c4648c3f92285bd3 | [log] [tgz] |
---|---|---|
author | Julius Werner <jwerner@chromium.org> | Thu Oct 18 14:21:33 2012 -0700 |
committer | Gerrit <chrome-bot@google.com> | Fri Oct 19 17:48:31 2012 -0700 |
tree | 17ef3f641075fd3498684a6cff79402157d47f6c | |
parent | 60ceaf336297ce536201a82e350c697f1a5b546d [diff] |
Log RTM_NEWLINK RTNL messages and possible problems in shill (temporary) Several recent bug reports document a problem where attached USB Ethernet adapters are not correctly detected by shill. The issue persists until reboot once it has happened, but is not generally reproducable. Logs show that the kernel correctly loads the appropriate driver, so the issue is believed to be caused by communication problems between the kernel and shill (via NETLINK_ROUTE sockets). This patch adds more detailed logging upon receiving netlink messages with the RTM_NEWLINK type in shill. The output is intentionally hacked in at the earliest possible point to be able to catch decoding errors. Also added additional logging to a possible netlink attribute decoding failure code path and to the later device creation (which might misidentify the link's "technology" parameter). This patch is intended to be temporary. It shall run on production systems until more reports of the problem (with now more detailed info) show up, which will hopefully help us nail it down. It should be rolled back as soon as enough data is available. The additional log burden is expected to be small (compared to shill's existing amount of log messages). BUG=chrome-os-partner:14952,chromium-os:35479 TEST=Add new network interfaces to the system (e.g. by plugging in a USB Ethernet adapter). Watch RTM_NEWLINK(...) and device creation messages appear in /var/log/messages. Change-Id: Ib8c0c423de0060d97b45da5a7bde6d03be4daadf Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/35983 Reviewed-by: Paul Stewart <pstew@chromium.org>