shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/dbus_service_proxy.h b/dbus_service_proxy.h
index 3d37518..4a20cfc 100644
--- a/dbus_service_proxy.h
+++ b/dbus_service_proxy.h
@@ -5,6 +5,8 @@
#ifndef SHILL_DBUS_SERVICE_PROXY_H_
#define SHILL_DBUS_SERVICE_PROXY_H_
+#include <string>
+
#include "shill/dbus_proxies/dbus-service.h"
#include "shill/dbus_service_proxy_interface.h"
@@ -27,7 +29,7 @@
class Proxy : public org::freedesktop::DBus_proxy,
public DBus::ObjectProxy {
public:
- Proxy(DBus::Connection *connection);
+ explicit Proxy(DBus::Connection *connection);
virtual ~Proxy();
void set_name_owner_changed_callback(