shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/mock_external_task.h b/mock_external_task.h
index 62c7455..8a3b979 100644
--- a/mock_external_task.h
+++ b/mock_external_task.h
@@ -5,6 +5,10 @@
#ifndef SHILL_MOCK_EXTERNAL_TASK_H_
#define SHILL_MOCK_EXTERNAL_TASK_H_
+#include <map>
+#include <string>
+#include <vector>
+
#include <gmock/gmock.h>
#include "shill/external_task.h"
@@ -12,7 +16,7 @@
namespace shill {
class MockExternalTask : public ExternalTask {
-public:
+ public:
MockExternalTask(ControlInterface *control,
GLib *glib,
const base::WeakPtr<RPCTaskDelegate> &task_delegate,
@@ -28,7 +32,7 @@
MOCK_METHOD0(Stop, void());
MOCK_METHOD0(OnDelete, void());
-private:
+ private:
DISALLOW_COPY_AND_ASSIGN(MockExternalTask);
};