shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/property_observer.h b/property_observer.h
index e024cdc..9b33af0 100644
--- a/property_observer.h
+++ b/property_observer.h
@@ -7,7 +7,7 @@
#include <base/basictypes.h>
#include <base/callback.h>
-#include <tr1/memory>
+#include <memory>
#include "shill/accessor_interface.h"
#include "shill/error.h"
@@ -25,7 +25,7 @@
public:
typedef base::Callback<void(const T &new_value)> Callback;
- PropertyObserver(std::tr1::shared_ptr<AccessorInterface<T>> accessor,
+ PropertyObserver(std::shared_ptr<AccessorInterface<T>> accessor,
Callback callback)
: accessor_(accessor), callback_(callback) {
Error unused_error;
@@ -49,7 +49,7 @@
private:
friend class PropertyObserverTest;
- std::tr1::shared_ptr<AccessorInterface<T>> accessor_;
+ std::shared_ptr<AccessorInterface<T>> accessor_;
Callback callback_;
T saved_value_;