shill: set ethernet_service signal strength to max. (so if it has to
compete with wifi_service, it isn't unfairly penalized.)
BUG=chromium-os:26529
TEST=unit tests
Collateral change: update WiFiService (and its unit tests) to
use Service::kStrengthMin and Service::kStrengthMax.
Change-Id: I208fd2ce7a8dba8dbd6c72ae2f8fdd8b90ed9c12
Reviewed-on: https://gerrit.chromium.org/gerrit/16403
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
diff --git a/wifi_service.cc b/wifi_service.cc
index 90c2033..ba6df5f 100644
--- a/wifi_service.cc
+++ b/wifi_service.cc
@@ -670,10 +670,10 @@
strength = 120 + signal_dbm; // Call -20dBm "perfect".
}
- if (strength > 100) {
- strength = 100;
- } else if (strength < 0) {
- strength = 0;
+ if (strength > kStrengthMax) {
+ strength = kStrengthMax;
+ } else if (strength < kStrengthMin) {
+ strength = kStrengthMin;
}
return strength;
}