commit | 9364c4c9a1e1f4bbb59c8d32ac97c928505fc8cb | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Tue Dec 06 17:12:42 2011 -0800 |
committer | Gerrit <chrome-bot@google.com> | Wed Dec 07 10:00:39 2011 -0800 |
tree | b24bc3154b6baaa365a597378b23e36b1d83017b | |
parent | 0ed0f2e84c366a90bca4a824b0adf18e9f243369 [diff] |
shill: Clean up GetDeviceTechnology Make GetDeviceTechnology more libbasey. This has the bonus of losing the fd leak that the previous code had. BUG=chromium-os:23849 TEST=Rerun unit tests (for regression), run on a real system: - Ensure lo is treated as "Unknown", usb0 (gobi) treated as cellular and wlan0 treated as wifi. Ensure correct VLOC messages displayed in each case. - Ensure (via monitoring of /proc/###/fd) that fd list for shill process remains constant over multiple plug/unplug events. Change-Id: I3c4fea5a74efa7d3a45b6a23c55806c1486cde8a Reviewed-on: https://gerrit.chromium.org/gerrit/12525 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Ready: Paul Stewart <pstew@chromium.org>