| commit | 96e35cf43e6d5aa2378cdae6fea507e5335d12bb | [log] [tgz] |
|---|---|---|
| author | Samuel Tan <samueltan@chromium.org> | Tue Oct 28 22:27:38 2014 -0700 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Wed Nov 05 21:14:40 2014 +0000 |
| tree | a77f6e6d69a1d5a5ce64fbc0029970797f2bf4ee | |
| parent | 127b341755731bd6ecc19e44b63c23c79e0b7cd1 [diff] |
shill: move shill WakeOnWiFiEnabled Manager DBus API to Device
Move WakeOnWiFiEnabled Manager DBus API to the Device DBus API so
that it is directly associated with a corresponding WiFi device.
Also rename all instances and variations of the substring "WakeOnWiFiEnabled"
to "WakeOnWiFiFeaturesEnabled" in variables and constant names. This is
to ensure consistency when referring to the run-time wake on WiFi enable
flag (i.e. "features"), so as to prevent confusion with the compile time
enable flag (i.e. DISABLE_WAKE_ON_WIFI).
CQ-DEPEND=CL:226302
BUG=chromium:427613
TEST=Run unit tests using the follow commands:
P2_TEST_FILTER="shill::*" FEATURES="test" USE="wake_on_wifi clang asan" \
emerge-samus shill
P2_TEST_FILTER="shill::*" FEATURES="test" USE="-wake_on_wifi clang asan" \
emerge-samus shill
Verify that all unit tests pass in both cases.
Manual testing as follows:
1) Build a test image for samus and boot into it.
2) Run the following command:
/usr/local/lib/flimflam/test/list-devices
3) Note the wireless NIC device name (should be /device/wlan0). Also
verify that the value of WakeOnWiFiFeaturesEnabled is "ssid".
4) Run the following command:
dbus-send --system --print-reply --dest=org.chromium.flimflam \
/device/wlan0 org.chromium.flimflam.Device.GetProperties
where /device/wlan0 is the wireless NIC device name from step 3.
Verify that "WakeOnWiFiFeaturesEnabled" is printed with a value of
"ssid".
5) Run the following command:
dbus-send --system --print-reply --dest=org.chromium.flimflam \
/device/wlan0 org.chromium.flimflam.Device.SetProperty \
string:WakeOnWiFiFeaturesEnabled \
variant:string:"packet_and_ssid"
Verify that no error message is returned.
6) Repeat step 4 and verify that the "WakeOnWiFiFeaturesEnabled" property is
now "packet_and_ssid".
7) Run the following command:
dbus-send --system --print-reply --dest=org.chromium.flimflam \
/device/wlan0 org.chromium.flimflam.Device.SetProperty \
string:WakeOnWiFiFeaturesEnabled variant:string:"blahblah"
8) Verify that the following error message is returned:
Error org.chromium.flimflam.InvalidArguments: Invalid Wake on WiFi feature
Change-Id: I16129800ddcee3113c3bc8407297522e8747be49
Reviewed-on: https://chromium-review.googlesource.com/226334
Tested-by: Samuel Tan <samueltan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>