commit | 97f317c08f8ae4f3dd131ac9a517f490b1f7b4e6 | [log] [tgz] |
---|---|---|
author | Prathmesh Prabhu <pprabhu@chromium.org> | Fri Mar 15 16:20:34 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Tue Mar 19 16:55:43 2013 -0700 |
tree | 04bee73234d3ec3816bab91453414bf517219d16 | |
parent | 39db5caaa3d07c3af9c575affcbb7313536de91d [diff] |
shill: Change ownership of activating_iccidstore Response to a bug report that a file created during the construction of activating_iccid_store object is left behind after some unit-tests. activating_iccid_store was owned by Cellular. Move it higher in the hierarchy to ModemInfo. This change causes the activating_iccid_store object to appear as an argument in constructor arguments for some more classes. The unit-tests for these classes no longer create the activating_iccid_store object, which means that the associated persistent file is not created. Fix unit-tests for this change. (1) Add extra constructor argument to some mocks to match the changed classes (2) mock activating_iccid_store in unit tests in cellular_capability_universal_unittest that used the actual object earlier. (3) activating_iccid_store_unittest.cc : Create temporary directory for the persistent file and delete it after the test. BUG=chromium:221397 TEST=Fixed unit-tests for the refactoring pass. Persistent file is not longer left behind by tests. 4GLTE activation works. Change-Id: I36876117cbc144c4405846e9604cdb3b35d296dc Reviewed-on: https://gerrit.chromium.org/gerrit/45786 Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>