shill: dbus_properties: Convert to callbacks instead of delegates
Use callbacks instead of proxies on the DBusPropertiesProxyInterface.
This makes the class consistent with the other proxies used for
cellular support, and in subsequent CLs will allow access to the
GetAll function without having to implement the Delegate interface.
Add a GetStrings method to dbus_properties.
BUG=none
TEST=run unit tests, run on a machine validate that changes in signal
strength are noticed.
Change-Id: I23e47f011c39a23f406ef62a52a5a613e55c55ed
Reviewed-on: https://gerrit.chromium.org/gerrit/20640
Reviewed-by: Jason Glasgow <jglasgow@chromium.org>
Tested-by: Jason Glasgow <jglasgow@chromium.org>
Commit-Ready: Jason Glasgow <jglasgow@chromium.org>
diff --git a/modem_manager.cc b/modem_manager.cc
index 54dd994..69ed70c 100644
--- a/modem_manager.cc
+++ b/modem_manager.cc
@@ -140,20 +140,6 @@
glib,
provider_db) {}
-void ModemManagerClassic::OnDBusPropertiesChanged(
- const string &/*interface*/,
- const DBusPropertiesMap &/*changed_properties*/,
- const vector<string> &/*invalidated_properties*/) {
- // Ignored.
-}
-
-void ModemManagerClassic::OnModemManagerPropertiesChanged(
- const string &/*interface*/,
- const DBusPropertiesMap &properties) {
- // Ignored
-}
-
-
ModemManagerClassic::~ModemManagerClassic() {}
void ModemManagerClassic::Connect(const string &supplied_owner) {
@@ -195,8 +181,7 @@
}
scoped_ptr<DBusPropertiesProxyInterface> properties_proxy(
- proxy_factory()->CreateDBusPropertiesProxy(this,
- modem->path(),
+ proxy_factory()->CreateDBusPropertiesProxy(modem->path(),
modem->owner()));
DBusPropertiesMap properties =
properties_proxy->GetAll(MM_MODEM_INTERFACE);