| commit | 9de146f8c257fc1a39f02d7ed4b3a99a8b520d66 | [log] [tgz] |
|---|---|---|
| author | Ben Chan <benchan@chromium.org> | Wed Sep 11 13:11:31 2013 -0700 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Wed Sep 11 23:38:56 2013 +0000 |
| tree | 2bc48e530b3a02a5be30e0fa785da839afec68a8 | |
| parent | 5d9a852d507e0ed4c4091bd05767a93169a6169f [diff] |
shill: cellular: Simplify modem disabling operation.
ModemManager disconnects all connected bearers when disabling the modem,
so shill does not need to explicitly disconnect bearers when the
cellular device is being disabled. This CL simplifies
CellularCapabilityUniversal::StopModem() to remove the explicit
disconnect call.
BUG=chromium:289695
TEST=Tested the following:
1. Build and run unit tests.
2. Run network_3GSmokeTest and network_3GStressEnable tests with E362,
ALT3100 and MU736.
3. Manually verify that the following via UI:
- Run "modem set-logging debug" from crosh.
- Connect to a cellular network.
- Disable mobile data.
- Check /var/log/net.log to make sure ModemManager disconnects the
bearer.
- Enable mobile data.
- The cellular network is available and connectable.
Change-Id: I772122fb057a2fbca0a7db9cc082a081c73466bc
Reviewed-on: https://chromium-review.googlesource.com/168992
Reviewed-by: Thieu Le <thieule@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>