| commit | a55469db27a5b7c46af9fb1cfb727f2989059925 | [log] [tgz] |
|---|---|---|
| author | Ben Chan <benchan@chromium.org> | Mon Jan 27 16:35:29 2014 -0800 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Wed Jan 29 11:07:15 2014 +0000 |
| tree | 13dd744e08faea2a7feedd112e99527f2f38b372 | |
| parent | 5100a87980fae5ac01b1dd9cf3a033313e97525b [diff] |
shill: Replace TestProxyFactory variants with MockProxyFactory.
This CL reduces the number of TestProxyFactory variants in unit tests as
follows:
- Add a ReturnAndReleasePointee Google Mock action, which can be used
with EXPECT_CALL on MockProxyFactory, to mimic how TestProxyFactory
handles the scoped_ptr of mock proxies.
- Use MockProxyFactor with EXPECT_CALL to mimic
TestProxyFactory::Create*Proxy methods.
- Check arguments passed to MockProxyFactory::Create*Proxy() via
EXPECT_CALL.
BUG=chromium:338623
TEST=`FEATURES=test emerge-{x86,amd64,arm}-generic shill`
Change-Id: Ieb0689f76feb105a2d1efaf1e7c52b4bc15fb8d7
Reviewed-on: https://chromium-review.googlesource.com/184033
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>