commit | a5995cf4c3b4b5d5660ad02b7d108cbd9352e2eb | [log] [tgz] |
---|---|---|
author | Wade Guthrie <wdg@chromium.org> | Tue Jul 30 09:31:16 2013 -0700 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Mon Sep 09 21:37:41 2013 +0000 |
tree | 18f1ba3635da032687cf3ea7e811a12d9db2c327 | |
parent | 2187efe10231adef9d9176fc32ebf3a72e8b6d42 [diff] |
shill: Removes log clutter from wifi_unittest.cc I got tired of trudging through the morass of uninteresting mock calls in the jungle of wifi unittest output, looking for the nugget of error message that would deliver me to jubilation. So I fixed it. Somewhat. This CL adds a bunch of checks for mock calls. Most of them are bound into 'ExpectXxx' methods which provide the additional benefit of enhanced readability, explaining what the tests are doing and expecting. Also, moved the declaration of some ScopedMockLogs closer to their use. And made them NiceScopedMockLogs. There's more that can be done (and more tests that could benefit from this) but I drew a line. For now. BUG=chromium:266398 TEST=unittest Change-Id: I8004d752a2c24aece2bfb7472510ec6fcd87b79a Reviewed-on: https://chromium-review.googlesource.com/63924 Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> Commit-Queue: Wade Guthrie <wdg@chromium.org>