commit a61593e58a41fb2d6c25e0b1c2405f5246f22699
author Paul Stewart <pstew@chromium.org> Fri Mar 23 13:06:21 2012 -0700
committer Gerrit <chrome-bot@google.com> Fri Mar 23 19:25:02 2012 -0700
tree 7b36b79a4837fcdbdbb85d7865912ce17eafc94f
parent 7f61e52dced33bd4cd5af1c7989ee6e59bf8f892

shill: Create a Mapped custom property accessor

Create an accessor that passes a property key to the get/set/clear.

BUG=chromium-os:28303
TEST=New unit tests

Change-Id: If9cb94cf60427c49c5e87c828b787fc6d17d1a0c
Reviewed-on: https://gerrit.chromium.org/gerrit/18988
Commit-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>

property_accessor_unittest.cc

diff --git a/property_accessor_unittest.cc b/property_accessor_unittest.cc
index f95abdf..b52fe19 100644
--- a/property_accessor_unittest.cc
+++ b/property_accessor_unittest.cc
@@ -10,6 +10,7 @@
 #include <vector>
 
 #include <base/basictypes.h>
+#include <base/stl_util.h>
 #include <gtest/gtest.h>
 #include <gmock/gmock.h>
 
@@ -378,4 +379,59 @@
   }
 }
 
+class StringMapWrapper {
+ public:
+  void Clear(const string &key, Error */*error*/) {
+    value_.erase(key);
+  }
+  string Get(const string &key, Error */*error*/) {
+    EXPECT_TRUE(ContainsKey(value_, key));
+    return value_[key];
+  }
+  void Set(const string &value, const string &key, Error */*error*/) {
+    value_[key] = value;
+  }
+
+  map<string,string> value_;
+};
+
+TEST(PropertyAccessorTest, CustomMappedAccessor) {
+  const string kKey = "entry_key";
+  const string kValue = "entry_value";
+  {
+    // Test reading.
+    StringMapWrapper wrapper;
+    CustomMappedAccessor<StringMapWrapper, string, string> accessor(
+        &wrapper, &StringMapWrapper::Clear, &StringMapWrapper::Get,
+        &StringMapWrapper::Set, kKey);
+    wrapper.value_[kKey] = kValue;
+    Error error;
+    EXPECT_EQ(kValue, accessor.Get(&error));
+    EXPECT_TRUE(error.IsSuccess());
+  }
+  {
+    // Test writing.
+    StringMapWrapper wrapper;
+    CustomMappedAccessor<StringMapWrapper, string, string> accessor(
+        &wrapper, &StringMapWrapper::Clear, &StringMapWrapper::Get,
+        &StringMapWrapper::Set, kKey);
+    Error error;
+    accessor.Set(kValue, &error);
+    EXPECT_TRUE(error.IsSuccess());
+    EXPECT_EQ(kValue, wrapper.value_[kKey]);
+  }
+  {
+    // Test clearing.
+    StringMapWrapper wrapper;
+    CustomMappedAccessor<StringMapWrapper, string, string> accessor(
+        &wrapper, &StringMapWrapper::Clear, &StringMapWrapper::Get,
+        &StringMapWrapper::Set, kKey);
+    wrapper.value_[kKey] = kValue;
+    Error error;
+    accessor.Clear(&error);
+    EXPECT_TRUE(error.IsSuccess());
+    EXPECT_FALSE(ContainsKey(wrapper.value_, kKey));
+  }
+}
+
 }  // namespace shill