| commit | a9f5dfe4a8db01a2da09ada36d494bec93c6d69f | [log] [tgz] |
|---|---|---|
| author | mukesh agrawal <quiche@chromium.org> | Tue Dec 16 12:56:36 2014 -0800 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Tue Dec 16 23:56:13 2014 +0000 |
| tree | 2883f0f9425c264d5fc440cf7118d0a41cc717af | |
| parent | 7116093da00d83a9b2a2200e5501fe138cbdd11e [diff] |
shill: fix bug in Manager::GetEnabledDeviceWithTechnology When looking for an enable device for a technology, we first filter the devices by technology, then return the first enabled device (if any). Due to a typo in a refactor, these two steps were not tied together. We would filter by technology, and place the results in the local variable |devices|. Then we would return the first enabled device from the member variable |devices_|. Resolve this by simplifying the interface of FilterByTechnology. While there: fix ordering of FRIEND_TEST declaration in device.h. BUG=chromium:397763 TEST=new unit test Change-Id: I990b09398a096bee07ce38aab15a42976a78b54d Reviewed-on: https://chromium-review.googlesource.com/236072 Trybot-Ready: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org>