| commit | ae30e9e4f9050a5a2c3b18d20f8bd23f20aa8f38 | [log] [tgz] |
|---|---|---|
| author | mukesh agrawal <quiche@chromium.org> | Tue May 28 14:09:16 2013 -0700 |
| committer | ChromeBot <chrome-bot@google.com> | Mon Jun 03 15:30:40 2013 -0700 |
| tree | 919f1edead565e7003f78efe0bd6701970440636 | |
| parent | 2623f1a26f13538a3ab2f88fffac5767d99d4191 [diff] |
shill: create external_task abstraction
This moves code out of L2TPIPSecDriver into a new ExternalTask
class, and updates the L2TPIPSecDriver code appropriately.
While there:
- fix a couple bug in L2TPIPSecDriverTest::ExpectInFlags.
(The function was returning early, and not checking the value
of the flag.)
- remove RpcTask::GetRpcInterfaceIdentifier, since the only
place it was called from was a test.
BUG=chromium:209938
TEST=unit tests, manual
Manual test
-----------
- connect to CrOS_WPA2_Buffalo2_AG300H_2.4GHz
- /usr/local/lib/flimflam/test/connect-vpn l2tpipsec-psk \
Cisco-ASA-173 172.22.22.173 \
Cisco-ASA-173 chromeos_psk \
CrOS_Password <password>
- check that ppp0 has an IP address
- egrep "l2tpipsec_vpn.+pppd: local" /var/log/net.log
(should match)
Change-Id: I54aed25f14597d0324249aaddba2095d296ded7d
Reviewed-on: https://gerrit.chromium.org/gerrit/57193
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>