commit b061f89e7088c7fba50b49ee5ac876619c9e8a7e
author Ben Chan <benchan@chromium.org> Wed Feb 27 17:46:55 2013 -0800
committer ChromeBot <chrome-bot@google.com> Mon Mar 04 16:05:26 2013 -0800
tree 994a186bab2ac5b13a725cb963bfa1511f63d3d4
parent 21f4096b66e7d16f211942fb2c27bd3a7ad0859e

Add a traffic monitor to detect abnormal scenarios.

This CL implements a traffic monitor to detect abnormal scenarios on an
network connection. The traffic monitor can be conditionally enabled on
a device. It starts periodically sampling the receive and transmit byte
counts on a enabled device after the device establishes a connection.
When it sees that there is outgoing traffic but no incoming traffic for
some sampling periods, it invokes a callback to notify such a scenario.

BUG=chromium-os:39433
TEST=Built and ran unit tests.

Change-Id: I22b43fae53365544f595a630bff1b8d90b478e95
Reviewed-on: https://gerrit.chromium.org/gerrit/44403
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>

device.h

diff --git a/device.h b/device.h
index 5afa9e4..70c595a 100644
--- a/device.h
+++ b/device.h
@@ -38,6 +38,7 @@
 class Manager;
 class Metrics;
 class RTNLHandler;
+class TrafficMonitor;
 
 // Device superclass.  Individual network interfaces types will inherit from
 // this class.
@@ -121,6 +122,10 @@
   // Returns true if portal detection was started.
   virtual bool RestartPortalDetection();
 
+  // Get receive and transmit byte counters.
+  virtual uint64 GetReceiveByteCount();
+  virtual uint64 GetTransmitByteCount();
+
   // Reset the persisted byte counters associated with the device.
   void ResetByteCounters();
 
@@ -205,7 +210,9 @@
   FRIEND_TEST(DeviceTest, SetEnabledPersistent);
   FRIEND_TEST(DeviceTest, SetServiceConnectedState);
   FRIEND_TEST(DeviceTest, Start);
+  FRIEND_TEST(DeviceTest, StartTrafficMonitor);
   FRIEND_TEST(DeviceTest, Stop);
+  FRIEND_TEST(DeviceTest, StopTrafficMonitor);
   FRIEND_TEST(ManagerTest, DeviceRegistrationAndStart);
   FRIEND_TEST(ManagerTest, ConnectedTechnologies);
   FRIEND_TEST(ManagerTest, DefaultTechnology);
@@ -324,6 +331,18 @@
   // Respond to a LinkMonitor failure in a Device-specific manner.
   virtual void OnLinkMonitorFailure();
 
+  // Initiates traffic monitoring if it's enabled via
+  // set_traffic_monitor_enabled() and returns true if the monitoring
+  // is started.
+  bool StartTrafficMonitor();
+
+  // Stops traffic monitoring if it is running.
+  void StopTrafficMonitor();
+
+  // Responds to a TrafficMonitor no-incoming-traffic failure in a
+  // Device-specific manner.
+  virtual void OnNoIncomingTraffic();
+
   // Set the state of the selected service, with checks to make sure
   // the service is already in a connected state before doing so.
   void SetServiceConnectedState(Service::ConnectState state);
@@ -358,6 +377,16 @@
   Manager *manager() const { return manager_; }
   const LinkMonitor *link_monitor() const { return link_monitor_.get(); }
   void set_link_monitor(LinkMonitor *link_monitor);
+  const TrafficMonitor *traffic_monitor() const {
+    return traffic_monitor_.get();
+  }
+
+  // Ownership of |traffic_monitor| is taken.
+  void set_traffic_monitor(TrafficMonitor *traffic_monitor);
+  bool traffic_monitor_enabled() const { return traffic_monitor_enabled_; }
+  void set_traffic_monitor_enabled(bool traffic_monitor_enabled) {
+    traffic_monitor_enabled_ = traffic_monitor_enabled;
+  }
 
  private:
   friend class CellularCapabilityTest;
@@ -407,9 +436,11 @@
   // Get the LinkMonitor's average response time.
   uint64 GetLinkMonitorResponseTime(Error *error);
 
-  // Get receive and transmit byte counters.
-  uint64 GetReceiveByteCount(Error *error);
-  uint64 GetTransmitByteCount(Error *error);
+  // Get receive and transmit byte counters. These methods simply wrap
+  // GetReceiveByteCount and GetTransmitByteCount in order to be used by
+  // HelpRegisterConstDerivedUint64.
+  uint64 GetReceiveByteCountProperty(Error *error);
+  uint64 GetTransmitByteCountProperty(Error *error);
 
   // |enabled_persistent_| is the value of the Powered property, as
   // read from the profile. If it is not found in the profile, it
@@ -458,6 +489,8 @@
   scoped_ptr<DeviceAdaptorInterface> adaptor_;
   scoped_ptr<PortalDetector> portal_detector_;
   scoped_ptr<LinkMonitor> link_monitor_;
+  scoped_ptr<TrafficMonitor> traffic_monitor_;
+  bool traffic_monitor_enabled_;
   base::Callback<void(const PortalDetector::Result &)>
       portal_detector_callback_;
   Technology::Identifier technology_;