commit b0b66df7532f6d602ae6746e38c8ef7e793874ab
author Nathan Williams <njw@chromium.org> Tue Apr 17 13:29:07 2012 -0400
committer Gerrit <chrome-bot@google.com> Tue Apr 17 14:44:22 2012 -0700
tree 81fdcb62cea9c0484ed4f731aed3cdfb178562fe
parent 8f1c835d879f82261a08257eb6f9677e6be51fda

shill: Add some more trivial properties to universal modems

BUG=None
TEST=list-devices, check Cellular.{ModelID,Manufacturer,FirmwareRevision}

Change-Id: I31f6cf6975024642281bcd4220a99b07d0fec819
Reviewed-on: https://gerrit.chromium.org/gerrit/20383
Reviewed-by: Jason Glasgow <jglasgow@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Nathan J. Williams <njw@chromium.org>
Tested-by: Nathan J. Williams <njw@chromium.org>

cellular_capability_universal.cc

diff --git a/cellular_capability_universal.cc b/cellular_capability_universal.cc
index 61e7acc..0f044aa 100644
--- a/cellular_capability_universal.cc
+++ b/cellular_capability_universal.cc
@@ -464,12 +464,29 @@
       // TODO(jglasgow): May eventually want to get SPDI, etc
     }
   }
+
   if (mdn_.empty()) {
     // TODO(njw): Switch to asynchronous calls (crosbug.com/17583).
     vector<string> numbers = modem_proxy_->OwnNumbers();
     if (numbers.size() > 0)
       mdn_ = numbers[0];
   }
+
+  if (model_id_.empty()) {
+    // TODO(njw): Switch to asynchronous calls (crosbug.com/17583).
+    model_id_ = modem_proxy_->Model();
+  }
+
+  if (manufacturer_.empty()) {
+    // TODO(njw): Switch to asynchronous calls (crosbug.com/17583).
+    manufacturer_ = modem_proxy_->Manufacturer();
+  }
+
+  if (firmware_revision_.empty()) {
+    // TODO(njw): Switch to asynchronous calls (crosbug.com/17583).
+    firmware_revision_ = modem_proxy_->Revision();
+  }
+
   GetRegistrationState();
 }