commit | b2c4a808fda1771cb4bdd86625ef2b3bba5ff0b5 | [log] [tgz] |
---|---|---|
author | Ben Chan <benchan@chromium.org> | Thu Nov 14 12:47:52 2013 -0800 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Mon Nov 18 19:07:19 2013 +0000 |
tree | 07f57d79672c24b14b29966948bcae38e642a949 | |
parent | 3d6b23824fb14aea7b846c6fc0e02fa10e26347a [diff] |
shill: cellular: Fix CellularCapabilityUniversalCDMA::IsRegistered(). A CDMA modem may register on a network but fail to determine the roaming status. ModemManager reports the CDMA (1xRTT/EVDO) registeration state as MM_MODEM_CDMA_REGISTRATION_STATE_REGISTERED. This CL fixes CellularCapabilityUniversalCDMA::IsRegistered() to include MM_MODEM_CDMA_REGISTRATION_STATE_REGISTERED as a 'registered' state. Otherwise, shill does not create a cellular service in such a scenario. BUG=chromium:319496 TEST=Tested the following: 1. Build and run unit tests. 2. Verify that shill creates a cellular service for a CDMA dongle (e.g. ZTE AC2738) that registers on a CDMA network but fails to determine the roaming status. 3. Verify that shill creates a cellular service for a CDMA dongle (e.g. Huawei E1561) that registers on a CDMA network and reports the registeration status as 'home'. Change-Id: I8b8d616a1965e237606aedef5c5bdce590f5fdaa Reviewed-on: https://chromium-review.googlesource.com/176871 Reviewed-by: Thieu Le <thieule@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>