commit ba40dd302d1f6f4c38b9449a4e83c3d470159ea1
author Darin Petkov <petkov@chromium.org> Mon Jul 11 20:06:39 2011 -0700
committer Darin Petkov <petkov@chromium.org> Tue Jul 12 16:37:14 2011 -0700
tree 4946b9055f3d184cd193a4aec11df1ed7ba223e3
parent b2e326bf37654683cdc8c0cbbab29d1af7910af8

shill: Initial support for loading and saving of services.

BUG=chromium-os:17255
TEST=unit tests

Change-Id: Ibf2721f72bfd44afbe6be9ac2cce0a2e978465eb
Reviewed-on: http://gerrit.chromium.org/gerrit/3954
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Darin Petkov <petkov@chromium.org>

service_unittest.cc

diff --git a/service_unittest.cc b/service_unittest.cc
index e47bd2e..9b5b023 100644
--- a/service_unittest.cc
+++ b/service_unittest.cc
@@ -20,16 +20,19 @@
 #include "shill/mock_control.h"
 #include "shill/mock_profile.h"
 #include "shill/mock_service.h"
+#include "shill/mock_store.h"
 #include "shill/property_store_unittest.h"
 #include "shill/shill_event.h"
 
 using std::map;
 using std::string;
 using std::vector;
-using ::testing::_;
-using ::testing::NiceMock;
-using ::testing::Return;
-using ::testing::Test;
+using testing::_;
+using testing::AtLeast;
+using testing::NiceMock;
+using testing::Return;
+using testing::StrictMock;
+using testing::Test;
 
 namespace shill {
 
@@ -58,6 +61,11 @@
 
 const char ServiceTest::kProfileName[] = "profile";
 
+TEST_F(ServiceTest, Constructor) {
+  EXPECT_TRUE(service_->save_credentials_);
+  EXPECT_EQ(Service::kCheckPortalAuto, service_->check_portal_);
+}
+
 TEST_F(ServiceTest, GetProperties) {
   EXPECT_CALL(*service_.get(), CalculateState()).WillRepeatedly(Return(""));
   EXPECT_CALL(*service_.get(), GetDeviceRpcId())
@@ -185,4 +193,71 @@
   }
 }
 
+TEST_F(ServiceTest, GetStorageIdentifier) {
+  EXPECT_EQ(kMockServiceName, service_->GetStorageIdentifier());
+}
+
+TEST_F(ServiceTest, Load) {
+  NiceMock<MockStore> storage;
+  const string id = kMockServiceName;
+  EXPECT_CALL(storage, ContainsGroup(id)).WillOnce(Return(true));
+  EXPECT_CALL(storage, GetString(id, _, _))
+      .Times(AtLeast(1))
+      .WillRepeatedly(Return(true));
+  EXPECT_TRUE(service_->Load(&storage));
+}
+
+TEST_F(ServiceTest, LoadFail) {
+  StrictMock<MockStore> storage;
+  const string id = kMockServiceName;
+  EXPECT_CALL(storage, ContainsGroup(kMockServiceName)).WillOnce(Return(false));
+  EXPECT_FALSE(service_->Load(&storage));
+}
+
+TEST_F(ServiceTest, SaveString) {
+  MockStore storage;
+  static const char kKey[] = "test-key";
+  static const char kData[] = "test-data";
+  EXPECT_CALL(storage, SetString(kMockServiceName, kKey, kData))
+      .WillOnce(Return(true));
+  service_->SaveString(&storage, kKey, kData, false, true);
+}
+
+TEST_F(ServiceTest, SaveStringCrypted) {
+  MockStore storage;
+  static const char kKey[] = "test-key";
+  static const char kData[] = "test-data";
+  EXPECT_CALL(storage, SetCryptedString(kMockServiceName, kKey, kData))
+      .WillOnce(Return(true));
+  service_->SaveString(&storage, kKey, kData, true, true);
+}
+
+TEST_F(ServiceTest, SaveStringDontSave) {
+  MockStore storage;
+  static const char kKey[] = "test-key";
+  EXPECT_CALL(storage, DeleteKey(kMockServiceName, kKey))
+      .WillOnce(Return(true));
+  service_->SaveString(&storage, kKey, "data", false, false);
+}
+
+TEST_F(ServiceTest, SaveStringEmpty) {
+  MockStore storage;
+  static const char kKey[] = "test-key";
+  EXPECT_CALL(storage, DeleteKey(kMockServiceName, kKey))
+      .WillOnce(Return(true));
+  service_->SaveString(&storage, kKey, "", true, true);
+}
+
+TEST_F(ServiceTest, Save) {
+  NiceMock<MockStore> storage;
+  const string id = kMockServiceName;
+  EXPECT_CALL(storage, SetString(id, _, _))
+      .Times(AtLeast(1))
+      .WillRepeatedly(Return(true));
+  EXPECT_CALL(storage, DeleteKey(id, _))
+      .Times(AtLeast(1))
+      .WillRepeatedly(Return(true));
+  EXPECT_TRUE(service_->Save(&storage));
+}
+
 }  // namespace shill