| commit | baeefdf544bfcfe2895e4e15c348db3f7ce4d45b | [log] [tgz] |
|---|---|---|
| author | Gary Morain <gmorain@chromium.org> | Mon Apr 30 14:53:35 2012 -0700 |
| committer | Gerrit <chrome-bot@google.com> | Tue May 08 10:30:28 2012 -0700 |
| tree | 9e3ed4a7686a97d5d529c88c863b53e4d4dce024 | |
| parent | 610977f3070730558b5cd8d4dd89c42be0410193 [diff] |
shill: Fix cellular PIN unlock There were three problems. 1) The properties of the modem were not being parsed when the modem was first started, and so the lock status of the modem was not known, which prevented the GUI from asking the user to enter a PIN. 2) When the modem is locked, it cannot be started successfully, but the software state of the modem was being changed to "enabled", preventing it from being enabled when the PIN was entered (you can't enable an already enabled modem). 3) When enabling a modem failed, the asynchronous enable function still thought the enable operation was in progress, preventing the enabling of the modem once the PIN is entered. BUG=chromium-os:29847 TEST=manual. Try to enable a PIN-locked GSM modem. Also added new unittests. Change-Id: I72258586c3ba59abbcc40e03b47d4b7b9e4b73da Reviewed-on: https://gerrit.chromium.org/gerrit/21562 Reviewed-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Jason Glasgow <jglasgow@chromium.org> Commit-Ready: Gary Morain <gmorain@chromium.org> Tested-by: Gary Morain <gmorain@chromium.org>