commit | bb985105b95110ae756be1b570a5e9084694785a | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Thu Jun 27 16:51:11 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Fri Jun 28 10:27:34 2013 -0700 |
tree | 5e48ac51d44d4c564692ce03c1fbe2d1df48179f | |
parent | 08757aa8221a55004d3ab0a6405c8e0113554fa7 [diff] |
shill: OpenVPNDriver: Fix user authentication default setting By default, OpenVPN is started with user authentication enabled if no certificate credentials are given. It is explicitly enabled if either user authentication is explicitly enabled or if a username is provided. However until this change, if a pkcs11 certificate ID was provided, OpenVPN would by default also use user authentication even if no user credentials were provided. This change disables user authentication by default in the pkcs11 certificate ID case, similar to certificate authentication. BUG=chromium:249363 TEST=Unit test. I ran into this problem while writing the TPM flavor of the OpenVPN network_VPNConnect autotest, and verified functionality using this test (as of https://gerrit.chromium.org/gerrit/60296) Change-Id: Ia59ff7717d57d2fa0d350db1d78f50171cf05a26 Reviewed-on: https://gerrit.chromium.org/gerrit/60294 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org>