shill: EapCredentials: Promote to a class

Promote the EapCredentials structure to a sovereign class with
a small set of getters and setters where necessary.  Otherwise,
move most of the member manipulation (creating arguments for
wpa_supplicant and wimax_manager, Load() and Save()) interior
to the class.  This involves a straightforwarnd but lengthy
refactor of just about everything that uses EapCredentials.
The EapCredentials object is ref-counted to allow it to be
shared between some services.  For this reason, move the
"remote_certification" property out of EapCredentials into
Service since this property is strictly per-service.

BUG=chromium:227434
TEST=Unit tests, wired 802.1x and wifi EAP-TLS autotests

Change-Id: I167e71e1d9c934bc328a0e1d73f638e1ff50d238
Reviewed-on: https://gerrit.chromium.org/gerrit/47973
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
24 files changed
tree: 22af0f75679e76ba1fd72b592eba4ceab6956aca
  1. bin/
  2. data/
  3. dbus_bindings/
  4. doc/
  5. shims/
  6. test-scripts/
  7. .gitignore
  8. accessor_interface.h
  9. activating_iccid_store.cc
  10. activating_iccid_store.h
  11. activating_iccid_store_unittest.cc
  12. adaptor_interfaces.h
  13. arp_client.cc
  14. arp_client.h
  15. arp_client_unittest.cc
  16. arp_packet.cc
  17. arp_packet.h
  18. arp_packet_unittest.cc
  19. async_connection.cc
  20. async_connection.h
  21. async_connection_unittest.cc
  22. attribute_list.cc
  23. attribute_list.h
  24. byte_string.cc
  25. byte_string.h
  26. byte_string_unittest.cc
  27. callback80211_metrics.cc
  28. callback80211_metrics.h
  29. callbacks.h
  30. cellular.cc
  31. cellular.h
  32. cellular_capability.cc
  33. cellular_capability.h
  34. cellular_capability_cdma.cc
  35. cellular_capability_cdma.h
  36. cellular_capability_cdma_unittest.cc
  37. cellular_capability_classic.cc
  38. cellular_capability_classic.h
  39. cellular_capability_classic_unittest.cc
  40. cellular_capability_gsm.cc
  41. cellular_capability_gsm.h
  42. cellular_capability_gsm_unittest.cc
  43. cellular_capability_universal.cc
  44. cellular_capability_universal.h
  45. cellular_capability_universal_unittest.cc
  46. cellular_error.cc
  47. cellular_error.h
  48. cellular_operator_info.cc
  49. cellular_operator_info.h
  50. cellular_operator_info_unittest.cc
  51. cellular_service.cc
  52. cellular_service.h
  53. cellular_service_unittest.cc
  54. cellular_unittest.cc
  55. certificate_file.cc
  56. certificate_file.h
  57. certificate_file_unittest.cc
  58. connection.cc
  59. connection.h
  60. connection_health_checker.cc
  61. connection_health_checker.h
  62. connection_health_checker_unittest.cc
  63. connection_unittest.cc
  64. control_interface.h
  65. control_netlink_attribute.cc
  66. control_netlink_attribute.h
  67. crypto_des_cbc.cc
  68. crypto_des_cbc.h
  69. crypto_des_cbc_unittest.cc
  70. crypto_interface.h
  71. crypto_provider.cc
  72. crypto_provider.h
  73. crypto_provider_unittest.cc
  74. crypto_rot47.cc
  75. crypto_rot47.h
  76. crypto_rot47_unittest.cc
  77. crypto_util_proxy.cc
  78. crypto_util_proxy.h
  79. crypto_util_proxy_unittest.cc
  80. dbus_adaptor.cc
  81. dbus_adaptor.h
  82. dbus_adaptor_unittest.cc
  83. dbus_control.cc
  84. dbus_control.h
  85. dbus_manager.cc
  86. dbus_manager.h
  87. dbus_manager_unittest.cc
  88. dbus_objectmanager_proxy.cc
  89. dbus_objectmanager_proxy.h
  90. dbus_objectmanager_proxy_interface.h
  91. dbus_properties.cc
  92. dbus_properties.h
  93. dbus_properties_proxy.cc
  94. dbus_properties_proxy.h
  95. dbus_properties_proxy_interface.h
  96. dbus_properties_unittest.cc
  97. dbus_property_matchers.h
  98. dbus_service_proxy.cc
  99. dbus_service_proxy.h
  100. dbus_service_proxy_interface.h
  101. default_profile.cc
  102. default_profile.h
  103. default_profile_unittest.cc
  104. device.cc
  105. device.h
  106. device_dbus_adaptor.cc
  107. device_dbus_adaptor.h
  108. device_info.cc
  109. device_info.h
  110. device_info_unittest.cc
  111. device_stub.h
  112. device_unittest.cc
  113. dhcp_config.cc
  114. dhcp_config.h
  115. dhcp_config_unittest.cc
  116. dhcp_provider.cc
  117. dhcp_provider.h
  118. dhcp_provider_unittest.cc
  119. dhcp_proxy_interface.h
  120. dhcpcd_proxy.cc
  121. dhcpcd_proxy.h
  122. diagnostics_reporter.cc
  123. diagnostics_reporter.h
  124. diagnostics_reporter_unittest.cc
  125. dns_client.cc
  126. dns_client.h
  127. dns_client_unittest.cc
  128. eap_credentials.cc
  129. eap_credentials.h
  130. eap_credentials_unittest.cc
  131. eap_listener.cc
  132. eap_listener.h
  133. eap_listener_unittest.cc
  134. eap_protocol.h
  135. endpoint.cc
  136. endpoint.h
  137. ephemeral_profile.cc
  138. ephemeral_profile.h
  139. error.cc
  140. error.h
  141. error_unittest.cc
  142. ethernet.cc
  143. ethernet.h
  144. ethernet_service.cc
  145. ethernet_service.h
  146. ethernet_service_unittest.cc
  147. ethernet_unittest.cc
  148. event_dispatcher.cc
  149. event_dispatcher.h
  150. file_io.cc
  151. file_io.h
  152. file_reader.cc
  153. file_reader.h
  154. file_reader_unittest.cc
  155. generic_netlink_message.cc
  156. generic_netlink_message.h
  157. geolocation_info.cc
  158. geolocation_info.h
  159. glib.cc
  160. glib.h
  161. glib_io_input_handler.cc
  162. glib_io_input_handler.h
  163. glib_io_ready_handler.cc
  164. glib_io_ready_handler.h
  165. HACKING
  166. hook_table.cc
  167. hook_table.h
  168. hook_table_unittest.cc
  169. http_proxy.cc
  170. http_proxy.h
  171. http_proxy_unittest.cc
  172. http_request.cc
  173. http_request.h
  174. http_request_unittest.cc
  175. http_url.cc
  176. http_url.h
  177. http_url_unittest.cc
  178. ieee80211.h
  179. io_handler.h
  180. ip_address.cc
  181. ip_address.h
  182. ip_address_unittest.cc
  183. ipconfig.cc
  184. ipconfig.h
  185. ipconfig_dbus_adaptor.cc
  186. ipconfig_dbus_adaptor.h
  187. ipconfig_unittest.cc
  188. key_file_store.cc
  189. key_file_store.h
  190. key_file_store_unittest.cc
  191. key_value_store.cc
  192. key_value_store.h
  193. key_value_store_unittest.cc
  194. l2tp_ipsec_driver.cc
  195. l2tp_ipsec_driver.h
  196. l2tp_ipsec_driver_unittest.cc
  197. LICENSE
  198. link_monitor.cc
  199. link_monitor.h
  200. link_monitor_unittest.cc
  201. logging.h
  202. Makefile
  203. manager.cc
  204. manager.h
  205. manager_dbus_adaptor.cc
  206. manager_dbus_adaptor.h
  207. manager_unittest.cc
  208. memory_log.cc
  209. memory_log.h
  210. memory_log_unittest.cc
  211. metrics.cc
  212. metrics.h
  213. metrics_unittest.cc
  214. minijail.cc
  215. minijail.h
  216. mm1_bearer_proxy.cc
  217. mm1_bearer_proxy.h
  218. mm1_bearer_proxy_interface.h
  219. mm1_modem_location_proxy.cc
  220. mm1_modem_location_proxy.h
  221. mm1_modem_location_proxy_interface.h
  222. mm1_modem_modem3gpp_proxy.cc
  223. mm1_modem_modem3gpp_proxy.h
  224. mm1_modem_modem3gpp_proxy_interface.h
  225. mm1_modem_modemcdma_proxy.cc
  226. mm1_modem_modemcdma_proxy.h
  227. mm1_modem_modemcdma_proxy_interface.h
  228. mm1_modem_proxy.cc
  229. mm1_modem_proxy.h
  230. mm1_modem_proxy_interface.h
  231. mm1_modem_simple_proxy.cc
  232. mm1_modem_simple_proxy.h
  233. mm1_modem_simple_proxy_interface.h
  234. mm1_modem_time_proxy.cc
  235. mm1_modem_time_proxy.h
  236. mm1_modem_time_proxy_interface.h
  237. mm1_sim_proxy.cc
  238. mm1_sim_proxy.h
  239. mm1_sim_proxy_interface.h
  240. mock_activating_iccid_store.cc
  241. mock_activating_iccid_store.h
  242. mock_adaptors.cc
  243. mock_adaptors.h
  244. mock_ares.cc
  245. mock_ares.h
  246. mock_arp_client.cc
  247. mock_arp_client.h
  248. mock_async_connection.cc
  249. mock_async_connection.h
  250. mock_cellular.cc
  251. mock_cellular.h
  252. mock_cellular_operator_info.cc
  253. mock_cellular_operator_info.h
  254. mock_cellular_service.cc
  255. mock_cellular_service.h
  256. mock_certificate_file.cc
  257. mock_certificate_file.h
  258. mock_connection.cc
  259. mock_connection.h
  260. mock_connection_health_checker.cc
  261. mock_connection_health_checker.h
  262. mock_control.cc
  263. mock_control.h
  264. mock_crypto_util_proxy.h
  265. mock_dbus_manager.cc
  266. mock_dbus_manager.h
  267. mock_dbus_objectmanager_proxy.cc
  268. mock_dbus_objectmanager_proxy.h
  269. mock_dbus_properties_proxy.cc
  270. mock_dbus_properties_proxy.h
  271. mock_dbus_service_proxy.cc
  272. mock_dbus_service_proxy.h
  273. mock_device.cc
  274. mock_device.h
  275. mock_device_info.cc
  276. mock_device_info.h
  277. mock_dhcp_config.cc
  278. mock_dhcp_config.h
  279. mock_dhcp_provider.cc
  280. mock_dhcp_provider.h
  281. mock_dhcp_proxy.cc
  282. mock_dhcp_proxy.h
  283. mock_diagnostics_reporter.cc
  284. mock_diagnostics_reporter.h
  285. mock_dns_client.cc
  286. mock_dns_client.h
  287. mock_eap_credentials.cc
  288. mock_eap_credentials.h
  289. mock_eap_listener.cc
  290. mock_eap_listener.h
  291. mock_ethernet.cc
  292. mock_ethernet.h
  293. mock_ethernet_service.cc
  294. mock_ethernet_service.h
  295. mock_event_dispatcher.cc
  296. mock_event_dispatcher.h
  297. mock_file_io.h
  298. mock_glib.cc
  299. mock_glib.h
  300. mock_http_request.cc
  301. mock_http_request.h
  302. mock_ipconfig.cc
  303. mock_ipconfig.h
  304. mock_link_monitor.cc
  305. mock_link_monitor.h
  306. mock_log.cc
  307. mock_log.h
  308. mock_log_unittest.cc
  309. mock_manager.cc
  310. mock_manager.h
  311. mock_metrics.cc
  312. mock_metrics.h
  313. mock_minijail.cc
  314. mock_minijail.h
  315. mock_mm1_bearer_proxy.cc
  316. mock_mm1_bearer_proxy.h
  317. mock_mm1_modem_location_proxy.cc
  318. mock_mm1_modem_location_proxy.h
  319. mock_mm1_modem_modem3gpp_proxy.cc
  320. mock_mm1_modem_modem3gpp_proxy.h
  321. mock_mm1_modem_modemcdma_proxy.cc
  322. mock_mm1_modem_modemcdma_proxy.h
  323. mock_mm1_modem_proxy.cc
  324. mock_mm1_modem_proxy.h
  325. mock_mm1_modem_simple_proxy.cc
  326. mock_mm1_modem_simple_proxy.h
  327. mock_mm1_modem_time_proxy.cc
  328. mock_mm1_modem_time_proxy.h
  329. mock_mm1_sim_proxy.cc
  330. mock_mm1_sim_proxy.h
  331. mock_modem.cc
  332. mock_modem.h
  333. mock_modem_cdma_proxy.cc
  334. mock_modem_cdma_proxy.h
  335. mock_modem_gobi_proxy.cc
  336. mock_modem_gobi_proxy.h
  337. mock_modem_gsm_card_proxy.cc
  338. mock_modem_gsm_card_proxy.h
  339. mock_modem_gsm_network_proxy.cc
  340. mock_modem_gsm_network_proxy.h
  341. mock_modem_info.cc
  342. mock_modem_info.h
  343. mock_modem_manager_proxy.cc
  344. mock_modem_manager_proxy.h
  345. mock_modem_proxy.cc
  346. mock_modem_proxy.h
  347. mock_modem_simple_proxy.cc
  348. mock_modem_simple_proxy.h
  349. mock_netlink_manager.h
  350. mock_netlink_socket.h
  351. mock_nss.cc
  352. mock_nss.h
  353. mock_openvpn_driver.cc
  354. mock_openvpn_driver.h
  355. mock_openvpn_management_server.cc
  356. mock_openvpn_management_server.h
  357. mock_portal_detector.cc
  358. mock_portal_detector.h
  359. mock_power_manager.cc
  360. mock_power_manager.h
  361. mock_power_manager_proxy.cc
  362. mock_power_manager_proxy.h
  363. mock_process_killer.cc
  364. mock_process_killer.h
  365. mock_profile.cc
  366. mock_profile.h
  367. mock_property_store.cc
  368. mock_property_store.h
  369. mock_proxy_factory.cc
  370. mock_proxy_factory.h
  371. mock_resolver.cc
  372. mock_resolver.h
  373. mock_routing_table.cc
  374. mock_routing_table.h
  375. mock_rtnl_handler.cc
  376. mock_rtnl_handler.h
  377. mock_service.cc
  378. mock_service.h
  379. mock_socket_info_reader.cc
  380. mock_socket_info_reader.h
  381. mock_sockets.cc
  382. mock_sockets.h
  383. mock_store.cc
  384. mock_store.h
  385. mock_supplicant_bss_proxy.cc
  386. mock_supplicant_bss_proxy.h
  387. mock_supplicant_eap_state_handler.cc
  388. mock_supplicant_eap_state_handler.h
  389. mock_supplicant_interface_proxy.cc
  390. mock_supplicant_interface_proxy.h
  391. mock_supplicant_network_proxy.cc
  392. mock_supplicant_network_proxy.h
  393. mock_supplicant_process_proxy.cc
  394. mock_supplicant_process_proxy.h
  395. mock_time.cc
  396. mock_time.h
  397. mock_traffic_monitor.cc
  398. mock_traffic_monitor.h
  399. mock_vpn.cc
  400. mock_vpn.h
  401. mock_vpn_driver.cc
  402. mock_vpn_driver.h
  403. mock_vpn_provider.cc
  404. mock_vpn_provider.h
  405. mock_vpn_service.cc
  406. mock_vpn_service.h
  407. mock_wifi.cc
  408. mock_wifi.h
  409. mock_wifi_provider.cc
  410. mock_wifi_provider.h
  411. mock_wifi_service.cc
  412. mock_wifi_service.h
  413. mock_wimax.cc
  414. mock_wimax.h
  415. mock_wimax_device_proxy.cc
  416. mock_wimax_device_proxy.h
  417. mock_wimax_manager_proxy.cc
  418. mock_wimax_manager_proxy.h
  419. mock_wimax_network_proxy.cc
  420. mock_wimax_network_proxy.h
  421. mock_wimax_provider.cc
  422. mock_wimax_provider.h
  423. mock_wimax_service.cc
  424. mock_wimax_service.h
  425. modem.cc
  426. modem.h
  427. modem_1.cc
  428. modem_1_unittest.cc
  429. modem_cdma_proxy.cc
  430. modem_cdma_proxy.h
  431. modem_cdma_proxy_interface.h
  432. modem_classic.cc
  433. modem_gobi_proxy.cc
  434. modem_gobi_proxy.h
  435. modem_gobi_proxy_interface.h
  436. modem_gsm_card_proxy.cc
  437. modem_gsm_card_proxy.h
  438. modem_gsm_card_proxy_interface.h
  439. modem_gsm_network_proxy.cc
  440. modem_gsm_network_proxy.h
  441. modem_gsm_network_proxy_interface.h
  442. modem_info.cc
  443. modem_info.h
  444. modem_info_unittest.cc
  445. modem_manager.cc
  446. modem_manager.h
  447. modem_manager_1.cc
  448. modem_manager_proxy.cc
  449. modem_manager_proxy.h
  450. modem_manager_proxy_interface.h
  451. modem_manager_unittest.cc
  452. modem_proxy.cc
  453. modem_proxy.h
  454. modem_proxy_interface.h
  455. modem_simple_proxy.cc
  456. modem_simple_proxy.h
  457. modem_simple_proxy_interface.h
  458. modem_unittest.cc
  459. netlink_attribute.cc
  460. netlink_attribute.h
  461. netlink_manager.cc
  462. netlink_manager.h
  463. netlink_manager_unittest.cc
  464. netlink_message.cc
  465. netlink_message.h
  466. netlink_message_unittest.cc
  467. netlink_socket.cc
  468. netlink_socket.h
  469. netlink_socket_unittest.cc
  470. nice_mock_control.cc
  471. nice_mock_control.h
  472. nl80211_attribute.cc
  473. nl80211_attribute.h
  474. nl80211_message.cc
  475. nl80211_message.h
  476. nss.cc
  477. nss.h
  478. nss_unittest.cc
  479. openvpn_driver.cc
  480. openvpn_driver.h
  481. openvpn_driver_unittest.cc
  482. openvpn_management_server.cc
  483. openvpn_management_server.h
  484. openvpn_management_server_unittest.cc
  485. portal_detector.cc
  486. portal_detector.h
  487. portal_detector_unittest.cc
  488. power_manager.cc
  489. power_manager.h
  490. power_manager_proxy.cc
  491. power_manager_proxy.h
  492. power_manager_proxy_interface.h
  493. power_manager_unittest.cc
  494. process_killer.cc
  495. process_killer.h
  496. process_killer_unittest.cc
  497. profile.cc
  498. profile.h
  499. profile_dbus_adaptor.cc
  500. profile_dbus_adaptor.h
  501. profile_dbus_property_exporter.cc
  502. profile_dbus_property_exporter.h
  503. profile_dbus_property_exporter_unittest.cc
  504. profile_unittest.cc
  505. property_accessor.h
  506. property_accessor_unittest.cc
  507. property_iterator.h
  508. property_store.cc
  509. property_store.h
  510. property_store_unittest.cc
  511. property_store_unittest.h
  512. provider_db_unittest.bfd
  513. proxy_factory.cc
  514. proxy_factory.h
  515. refptr_types.h
  516. resolver.cc
  517. resolver.h
  518. resolver_unittest.cc
  519. routing_table.cc
  520. routing_table.h
  521. routing_table_entry.h
  522. routing_table_unittest.cc
  523. rpc_task.cc
  524. rpc_task.h
  525. rpc_task_dbus_adaptor.cc
  526. rpc_task_dbus_adaptor.h
  527. rpc_task_unittest.cc
  528. rtnl_handler.cc
  529. rtnl_handler.h
  530. rtnl_handler_unittest.cc
  531. rtnl_listener.cc
  532. rtnl_listener.h
  533. rtnl_listener_unittest.cc
  534. rtnl_message.cc
  535. rtnl_message.h
  536. rtnl_message_unittest.cc
  537. scope_logger.cc
  538. scope_logger.h
  539. scope_logger_unittest.cc
  540. service.cc
  541. service.h
  542. service_dbus_adaptor.cc
  543. service_dbus_adaptor.h
  544. service_sorter.h
  545. service_under_test.cc
  546. service_under_test.h
  547. service_unittest.cc
  548. shill_ares.cc
  549. shill_ares.h
  550. shill_config.cc
  551. shill_config.h
  552. shill_daemon.cc
  553. shill_daemon.h
  554. shill_main.cc
  555. shill_test_config.cc
  556. shill_test_config.h
  557. shill_time.cc
  558. shill_time.h
  559. shill_unittest.cc
  560. socket_info.cc
  561. socket_info.h
  562. socket_info_reader.cc
  563. socket_info_reader.h
  564. socket_info_reader_unittest.cc
  565. socket_info_unittest.cc
  566. sockets.cc
  567. sockets.h
  568. static_ip_parameters.cc
  569. static_ip_parameters.h
  570. static_ip_parameters_unittest.cc
  571. store_interface.h
  572. supplicant_bss_proxy.cc
  573. supplicant_bss_proxy.h
  574. supplicant_bss_proxy_interface.h
  575. supplicant_eap_state_handler.cc
  576. supplicant_eap_state_handler.h
  577. supplicant_eap_state_handler_unittest.cc
  578. supplicant_event_delegate_interface.h
  579. supplicant_interface_proxy.cc
  580. supplicant_interface_proxy.h
  581. supplicant_interface_proxy_interface.h
  582. supplicant_network_proxy.cc
  583. supplicant_network_proxy.h
  584. supplicant_network_proxy_interface.h
  585. supplicant_process_proxy.cc
  586. supplicant_process_proxy.h
  587. supplicant_process_proxy_interface.h
  588. technology.cc
  589. technology.h
  590. technology_unittest.cc
  591. TESTING
  592. testrunner.cc
  593. traffic_monitor.cc
  594. traffic_monitor.h
  595. traffic_monitor_unittest.cc
  596. virtio_ethernet.cc
  597. virtio_ethernet.h
  598. vpn.cc
  599. vpn.h
  600. vpn_driver.cc
  601. vpn_driver.h
  602. vpn_driver_unittest.cc
  603. vpn_provider.cc
  604. vpn_provider.h
  605. vpn_provider_unittest.cc
  606. vpn_service.cc
  607. vpn_service.h
  608. vpn_service_unittest.cc
  609. vpn_unittest.cc
  610. wifi.cc
  611. wifi.h
  612. wifi_endpoint.cc
  613. wifi_endpoint.h
  614. wifi_endpoint_unittest.cc
  615. wifi_provider.cc
  616. wifi_provider.h
  617. wifi_provider_unittest.cc
  618. wifi_service.cc
  619. wifi_service.h
  620. wifi_service_unittest.cc
  621. wifi_unittest.cc
  622. wimax.cc
  623. wimax.h
  624. wimax_device_proxy.cc
  625. wimax_device_proxy.h
  626. wimax_device_proxy_interface.h
  627. wimax_manager_proxy.cc
  628. wimax_manager_proxy.h
  629. wimax_manager_proxy_interface.h
  630. wimax_network_proxy.cc
  631. wimax_network_proxy.h
  632. wimax_network_proxy_interface.h
  633. wimax_provider.cc
  634. wimax_provider.h
  635. wimax_provider_unittest.cc
  636. wimax_service.cc
  637. wimax_service.h
  638. wimax_service_unittest.cc
  639. wimax_unittest.cc
  640. wpa_supplicant.cc
  641. wpa_supplicant.h
  642. wpa_supplicant_unittest.cc