commit c529c83ca6b40367d53a2c42a47bbc40e70f6f39
author Darin Petkov <petkov@chromium.org> Wed Apr 18 14:59:42 2012 +0200
committer Gerrit <chrome-bot@google.com> Thu Apr 19 11:00:45 2012 -0700
tree 4706384cad7cdc8040abc9a713bf88c803b41933
parent 4f5e5490fb72f53a76598e8c0f3c17e2f4e313d6

shill: Reduce default KeyFileStore logging.

It seems that lookup failures are mostly noise and it should be up to
the client to log them as errors when the key is expected to be found.

BUG=none
TEST=ran on device

Change-Id: I015aeae807d4f800e70e434e9811960a0a7a24ab
Reviewed-on: https://gerrit.chromium.org/gerrit/20455
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>

key_file_store.cc

diff --git a/key_file_store.cc b/key_file_store.cc
index fa823aa..4ec9abc 100644
--- a/key_file_store.cc
+++ b/key_file_store.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -166,8 +166,8 @@
   gchar *data =
       glib_->KeyFileGetString(key_file_, group.c_str(), key.c_str(), &error);
   if (!data) {
-    LOG(ERROR) << "Failed to lookup (" << group << ":" << key << "): "
-               << glib_->ConvertErrorToMessage(error);
+    string s = glib_->ConvertErrorToMessage(error);
+    VLOG(10) << "Failed to lookup (" << group << ":" << key << "): " << s;
     return false;
   }
   if (value) {
@@ -193,8 +193,8 @@
   gboolean data =
       glib_->KeyFileGetBoolean(key_file_, group.c_str(), key.c_str(), &error);
   if (error) {
-    LOG(ERROR) << "Failed to lookup (" << group << ":" << key << "): "
-               << glib_->ConvertErrorToMessage(error);
+    string s = glib_->ConvertErrorToMessage(error);
+    VLOG(10) << "Failed to lookup (" << group << ":" << key << "): " << s;
     return false;
   }
   if (value) {
@@ -219,8 +219,8 @@
   gint data =
       glib_->KeyFileGetInteger(key_file_, group.c_str(), key.c_str(), &error);
   if (error) {
-    LOG(ERROR) << "Failed to lookup (" << group << ":" << key << "): "
-               << glib_->ConvertErrorToMessage(error);
+    string s = glib_->ConvertErrorToMessage(error);
+    VLOG(10) << "Failed to lookup (" << group << ":" << key << "): " << s;
     return false;
   }
   if (value) {
@@ -247,8 +247,8 @@
                                              &length,
                                              &error);
   if (!data) {
-    LOG(ERROR) << "Failed to lookup (" << group << ":" << key << "): "
-               << glib_->ConvertErrorToMessage(error);
+    string s = glib_->ConvertErrorToMessage(error);
+    VLOG(10) << "Failed to lookup (" << group << ":" << key << "): " << s;
     return false;
   }
   if (value) {