commit | a027707108f1e8d262f6adfb85c4ef7c31f8800a | [log] [tgz] |
---|---|---|
author | Samuel Tan <samueltan@chromium.org> | Wed Nov 12 20:38:45 2014 -0800 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Fri Nov 14 01:42:35 2014 +0000 |
tree | 23fbca1153ad0b1e049eb769bd1d0164fb8cd2a4 | |
parent | 6e744f7215d5e02dcda7a130102f55ca6222ede9 [diff] |
shill: always allow modification of wake on packet connections Remove run-time wake on WiFi feature flag check from WakeOnWiFi::AddWakeOnPacketConnection, WakeOnWiFi::RemoveWakeOnPacketConnection, and WakeOnWiFi::RemoveAllWakeOnPacketConnections so that wake-on-packet connection programming and deprogramming requests are "remembered" even when the wake-on-packet feature is disabled at runtime. BUG=chromium:432347 TEST=Compile and run unit tests with the following commands: P2_TEST_FILTER="shill::*" FEATURES="test" USE="wake_on_wifi \ clang asan" emerge-samus shill' P2_TEST_FILTER="shill::*" FEATURES="test" USE="-wake_on_wifi \ clang asan" emerge-samus shill Manual testing as follows: 1) Build a test image for samus and boot into it. 2) Connect the samus to an AP. 3) Run the following crosh command: set_wake_on_wifi none 4) Run the following command: dbus-send --system --print-reply --dest=org.chromium.flimflam \ /device/wlan0 \ org.chromium.flimflam.Device.AddWakeOnPacketConnection \ string:"1.1.1.1" where "1.1.1.1" is the IP address of the AP. 5) Suspend the samus using the following crosh command: powerd_dbus_suspend Wait 10 seconds for the system to fully suspend. 6) Ping the samus from the AP. 7) Verify that the samus does not wake up on suspend upon receiving the ping 8) Wake the samus by pressing any button on the keyboard. 9) Run the following crosh command: set_wake_on_wifi packet 10) Repeat step 5-6. 11) Verify that the samus wakes up from suspend upon receiving the ping. (Note: might have to wait p to 10 seconds for this to happen) Change-Id: Iaf43d56498c798cbef9013b2e580d01b4bde6db4 Reviewed-on: https://chromium-review.googlesource.com/229670 Tested-by: Samuel Tan <samueltan@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Samuel Tan <samueltan@chromium.org>