commit c64fe5e866c5f97a5e5676b28931bc9f6d81946a
author Darin Petkov <petkov@chromium.org> Wed Jan 11 12:46:13 2012 +0100
committer Gerrit <chrome-bot@google.com> Wed Jan 11 08:47:53 2012 -0800
tree 65de356480d8b9f3bd72a69164609594d46fe66c
parent 58a577b23de1478a72135410d146625ffd00e909

shill: Make all device *PIN service methods asynchronous.

BUG=chromium-os:24955
TEST=unit tests

Change-Id: Id7bb736e4d18331440fa6652726f694d01d46a42
Reviewed-on: https://gerrit.chromium.org/gerrit/13977
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Eric Shienbrood <ers@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>

device.cc

diff --git a/device.cc b/device.cc
index e5b6824..6e8a04c 100644
--- a/device.cc
+++ b/device.cc
@@ -180,31 +180,41 @@
                         "Device doesn't support network registration.");
 }
 
-void Device::RequirePIN(const string &/*pin*/, bool /*require*/, Error *error) {
-  Error::PopulateAndLog(error, Error::kNotSupported,
-                        "Device doesn't support RequirePIN.");
+void Device::RequirePIN(
+    const string &/*pin*/, bool /*require*/, ReturnerInterface *returner) {
+  VLOG(2) << __func__;
+  Error error;
+  Error::PopulateAndLog(
+      &error, Error::kNotSupported, "Device doesn't support RequirePIN.");
+  returner->ReturnError(error);
 }
 
 void Device::EnterPIN(const string &/*pin*/, ReturnerInterface *returner) {
   VLOG(2) << __func__;
   Error error;
-  Error::PopulateAndLog(&error, Error::kNotSupported,
-                        "Device doesn't support EnterPIN.");
+  Error::PopulateAndLog(
+      &error, Error::kNotSupported, "Device doesn't support EnterPIN.");
   returner->ReturnError(error);
 }
 
 void Device::UnblockPIN(const string &/*unblock_code*/,
                         const string &/*pin*/,
-                        Error *error) {
-  Error::PopulateAndLog(error, Error::kNotSupported,
-                        "Device doesn't support UnblockPIN.");
+                        ReturnerInterface *returner) {
+  VLOG(2) << __func__;
+  Error error;
+  Error::PopulateAndLog(
+      &error, Error::kNotSupported, "Device doesn't support UnblockPIN.");
+  returner->ReturnError(error);
 }
 
 void Device::ChangePIN(const string &/*old_pin*/,
                        const string &/*new_pin*/,
-                       Error *error) {
-  Error::PopulateAndLog(error, Error::kNotSupported,
-                        "Device doesn't support ChangePIN.");
+                       ReturnerInterface *returner) {
+  VLOG(2) << __func__;
+  Error error;
+  Error::PopulateAndLog(
+      &error, Error::kNotSupported, "Device doesn't support ChangePIN.");
+  returner->ReturnError(error);
 }
 
 void Device::DisableIPv6() {