| commit | c7e63afa9cfabf9aa022a0bf8e9ec5340f5d13bf | [log] [tgz] |
|---|---|---|
| author | Arman Uguray <armansito@chromium.org> | Thu Jun 13 17:07:32 2013 -0700 |
| committer | ChromeBot <chrome-bot@google.com> | Thu Jun 13 22:16:08 2013 -0700 |
| tree | a5e51129214e08991713f5f210f893b22e8ef72d | |
| parent | 3c5e2b347c4cdc76a6395a0863e174aed946902e [diff] |
shill: cellular: Update UnlockRequired and UnlockRetries separately.
Before this CL, if shill received a PropertiesChanged signal from
ModemManager that contained a value for 'UnlockRetries' but not for
'UnlockRequired' and the SIM was locked at the time, it incorrectly
updated the value of the "Cellular.SIMLockStatus/1/LockType" property to
'""'. Chrome uses this value to determine that the SIM is not locked and
thus this caused the UI to behave incorrectly if the user entered an
incorrect PIN.
BUG=chromium:249550
TEST=(1) Build and run unit tests.
(2) On a device with an Icera or LTE modem that works with
ModemManager AND for which the plugin implements reporting the
'UnlockRetries' property:
- Without this CL: Entering an incorrect PIN when the SIM is
locked will cause the PIN dialog to display no error and
disappear and the modem will remain disabled. Attempting
to unlock the modem through the UI will not be possible
until shill is restarted.
- With this CL: Entering an incorrect PIN when the SIM is
locked will cause the PIN dialog to report that the PIN
was incorrect and will show the correct number of unlock
retries left.
Change-Id: Ib018d0424c22a8d48502c1c1112b14565fcf12d0
Reviewed-on: https://gerrit.chromium.org/gerrit/58606
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>