shill: Emit more property change notifications for Services.
Add property change notifications for all the Service properties that
Chrome currently pays attention to. Also add unit tests for these
property change notifications.
While there:
- add some more tips to TESTING
- update service-api documentation for AutoConnect
(it is settable for non-favorite services, and has been for
some time)
- update some ServiceTests to no longer set_favorite before
changing AutoConnect (set_favorite is no longer necessary,
as noted above)
- clarify service-api documentation for Device property
- make the security_ field of WiFiService const (it is only
set in the ctor, and designating it const makes it obvious
why there's no property change for it)
- fix bug where VPNService would change the Favorite property,
but not signal the change
BUG=chromium:230329
TEST=new unit tests
Change-Id: Ia387b1ab90fa80fd218cd69e0fd8126ff4c5a2ae
Reviewed-on: https://gerrit.chromium.org/gerrit/48459
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
diff --git a/TESTING b/TESTING
index 2d4d226..f93d4a8 100644
--- a/TESTING
+++ b/TESTING
@@ -38,10 +38,22 @@
(chroot)$ GTEST_ARGS="--v=1000 --gtest_filter=WiFiPropertyTest.*" \
CXXFLAGS=-g cros_workon_make --board x86-generic --reconf --test shill
+- if you want to set a breakpoint in gdb, make sure to include the shill
+ namespace. e.g., run
+ (cros-gdb) b shill::EthernetService::GetStorageIdentifier
+ Breakpoint 2 at 0x5555563cc270: file ethernet_service.cc, line 63.
+ rather than
+ (cros-gdb) b EthernetService::GetStorageIdentifier
+ Function "EthernetService::GetStorageIdentifier" not defined.
+ Make breakpoint pending on future shared library load? (y or [n]) n
+
- alternate build arguments:
- to see the actual compiler commands that are run:
- (chroot)$ CFLAGS="-print-cmdline" cros_workon_make --reconf \
- --board=link shill
+ - to see the actual compiler commands that are run:
+ (chroot)$ CFLAGS="-print-cmdline" cros_workon_make --reconf \
+ --board=link shill
+ - to abort compilation on the first error
+ (chroot)$ MAKEFLAGS="--stop" cros_workon_make --test --board=link \
+ --reconf shill
Running integration tests
-------------------------