shill: EthernetService: Fix auto-connect-by-default

Fix a nasty typo which prevented EthernetService from overriding
the parent class IsAutoConnectByDefault.  Add unit tests.  Add
belt-and-suspenders by also overriding the SetAutoConnect RPC
settter to prevent AutoConnect from being set over the control
interface.

BUG=chromium-os:32709
TEST=Unit tests

Change-Id: I683333b915cb747ccb241512f66d2fb3f1efca3a
Reviewed-on: https://gerrit.chromium.org/gerrit/30557
Commit-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
7 files changed
tree: ff060ef2d4477a99cef3855df2e5e1f076d73c15
  1. dbus_bindings/
  2. doc/
  3. .gitignore
  4. accessor_interface.h
  5. adaptor_interfaces.h
  6. arp_client.cc
  7. arp_client.h
  8. arp_client_unittest.cc
  9. arp_packet.cc
  10. arp_packet.h
  11. arp_packet_unittest.cc
  12. async_connection.cc
  13. async_connection.h
  14. async_connection_unittest.cc
  15. byte_string.cc
  16. byte_string.h
  17. byte_string_unittest.cc
  18. callbacks.h
  19. cellular.cc
  20. cellular.h
  21. cellular_capability.cc
  22. cellular_capability.h
  23. cellular_capability_cdma.cc
  24. cellular_capability_cdma.h
  25. cellular_capability_cdma_unittest.cc
  26. cellular_capability_classic.cc
  27. cellular_capability_classic.h
  28. cellular_capability_classic_unittest.cc
  29. cellular_capability_gsm.cc
  30. cellular_capability_gsm.h
  31. cellular_capability_gsm_unittest.cc
  32. cellular_capability_universal.cc
  33. cellular_capability_universal.h
  34. cellular_capability_universal_unittest.cc
  35. cellular_error.cc
  36. cellular_error.h
  37. cellular_service.cc
  38. cellular_service.h
  39. cellular_service_unittest.cc
  40. cellular_unittest.cc
  41. connection.cc
  42. connection.h
  43. connection_unittest.cc
  44. control_interface.h
  45. crypto_des_cbc.cc
  46. crypto_des_cbc.h
  47. crypto_des_cbc_unittest.cc
  48. crypto_interface.h
  49. crypto_provider.cc
  50. crypto_provider.h
  51. crypto_provider_unittest.cc
  52. crypto_rot47.cc
  53. crypto_rot47.h
  54. crypto_rot47_unittest.cc
  55. dbus_adaptor.cc
  56. dbus_adaptor.h
  57. dbus_adaptor_unittest.cc
  58. dbus_control.cc
  59. dbus_control.h
  60. dbus_manager.cc
  61. dbus_manager.h
  62. dbus_manager_unittest.cc
  63. dbus_objectmanager_proxy.cc
  64. dbus_objectmanager_proxy.h
  65. dbus_objectmanager_proxy_interface.h
  66. dbus_properties.cc
  67. dbus_properties.h
  68. dbus_properties_proxy.cc
  69. dbus_properties_proxy.h
  70. dbus_properties_proxy_interface.h
  71. dbus_properties_unittest.cc
  72. dbus_property_matchers.h
  73. dbus_service_proxy.cc
  74. dbus_service_proxy.h
  75. dbus_service_proxy_interface.h
  76. default_profile.cc
  77. default_profile.h
  78. default_profile_unittest.cc
  79. device.cc
  80. device.h
  81. device_dbus_adaptor.cc
  82. device_dbus_adaptor.h
  83. device_info.cc
  84. device_info.h
  85. device_info_unittest.cc
  86. device_stub.h
  87. device_unittest.cc
  88. dhcp_config.cc
  89. dhcp_config.h
  90. dhcp_config_unittest.cc
  91. dhcp_provider.cc
  92. dhcp_provider.h
  93. dhcp_provider_unittest.cc
  94. dhcp_proxy_interface.h
  95. dhcpcd_proxy.cc
  96. dhcpcd_proxy.h
  97. dns_client.cc
  98. dns_client.h
  99. dns_client_unittest.cc
  100. endpoint.cc
  101. endpoint.h
  102. ephemeral_profile.cc
  103. ephemeral_profile.h
  104. error.cc
  105. error.h
  106. error_unittest.cc
  107. ethernet.cc
  108. ethernet.h
  109. ethernet_service.cc
  110. ethernet_service.h
  111. ethernet_service_unittest.cc
  112. event_dispatcher.cc
  113. event_dispatcher.h
  114. glib.cc
  115. glib.h
  116. glib_io_input_handler.cc
  117. glib_io_input_handler.h
  118. glib_io_ready_handler.cc
  119. glib_io_ready_handler.h
  120. HACKING
  121. hook_table.cc
  122. hook_table.h
  123. hook_table_unittest.cc
  124. http_proxy.cc
  125. http_proxy.h
  126. http_proxy_unittest.cc
  127. http_request.cc
  128. http_request.h
  129. http_request_unittest.cc
  130. http_url.cc
  131. http_url.h
  132. http_url_unittest.cc
  133. ieee80211.h
  134. io_handler.h
  135. ip_address.cc
  136. ip_address.h
  137. ip_address_unittest.cc
  138. ipconfig.cc
  139. ipconfig.h
  140. ipconfig_dbus_adaptor.cc
  141. ipconfig_dbus_adaptor.h
  142. ipconfig_unittest.cc
  143. key_file_store.cc
  144. key_file_store.h
  145. key_file_store_unittest.cc
  146. key_value_store.cc
  147. key_value_store.h
  148. key_value_store_matcher.h
  149. key_value_store_unittest.cc
  150. l2tp_ipsec_driver.cc
  151. l2tp_ipsec_driver.h
  152. l2tp_ipsec_driver_unittest.cc
  153. LICENSE
  154. link_monitor.cc
  155. link_monitor.h
  156. link_monitor_unittest.cc
  157. logging.h
  158. Makefile
  159. manager.cc
  160. manager.h
  161. manager_dbus_adaptor.cc
  162. manager_dbus_adaptor.h
  163. manager_unittest.cc
  164. memory_log.cc
  165. memory_log.h
  166. memory_log_unittest.cc
  167. metrics.cc
  168. metrics.h
  169. metrics_unittest.cc
  170. minijail.cc
  171. minijail.h
  172. mm1_modem_modem3gpp_proxy.cc
  173. mm1_modem_modem3gpp_proxy.h
  174. mm1_modem_modem3gpp_proxy_interface.h
  175. mm1_modem_modemcdma_proxy.cc
  176. mm1_modem_modemcdma_proxy.h
  177. mm1_modem_modemcdma_proxy_interface.h
  178. mm1_modem_proxy.cc
  179. mm1_modem_proxy.h
  180. mm1_modem_proxy_interface.h
  181. mm1_modem_simple_proxy.cc
  182. mm1_modem_simple_proxy.h
  183. mm1_modem_simple_proxy_interface.h
  184. mm1_sim_proxy.cc
  185. mm1_sim_proxy.h
  186. mm1_sim_proxy_interface.h
  187. mock_adaptors.cc
  188. mock_adaptors.h
  189. mock_ares.cc
  190. mock_ares.h
  191. mock_arp_client.cc
  192. mock_arp_client.h
  193. mock_async_connection.cc
  194. mock_async_connection.h
  195. mock_cellular.cc
  196. mock_cellular.h
  197. mock_cellular_service.cc
  198. mock_cellular_service.h
  199. mock_connection.cc
  200. mock_connection.h
  201. mock_control.cc
  202. mock_control.h
  203. mock_dbus_manager.cc
  204. mock_dbus_manager.h
  205. mock_dbus_objectmanager_proxy.cc
  206. mock_dbus_objectmanager_proxy.h
  207. mock_dbus_properties_proxy.cc
  208. mock_dbus_properties_proxy.h
  209. mock_dbus_service_proxy.cc
  210. mock_dbus_service_proxy.h
  211. mock_device.cc
  212. mock_device.h
  213. mock_device_info.cc
  214. mock_device_info.h
  215. mock_dhcp_config.cc
  216. mock_dhcp_config.h
  217. mock_dhcp_provider.cc
  218. mock_dhcp_provider.h
  219. mock_dhcp_proxy.cc
  220. mock_dhcp_proxy.h
  221. mock_dns_client.cc
  222. mock_dns_client.h
  223. mock_ethernet.cc
  224. mock_ethernet.h
  225. mock_event_dispatcher.cc
  226. mock_event_dispatcher.h
  227. mock_glib.cc
  228. mock_glib.h
  229. mock_http_request.cc
  230. mock_http_request.h
  231. mock_ipconfig.cc
  232. mock_ipconfig.h
  233. mock_link_monitor.cc
  234. mock_link_monitor.h
  235. mock_log.cc
  236. mock_log.h
  237. mock_log_unittest.cc
  238. mock_manager.cc
  239. mock_manager.h
  240. mock_metrics.cc
  241. mock_metrics.h
  242. mock_minijail.cc
  243. mock_minijail.h
  244. mock_mm1_modem_modem3gpp_proxy.cc
  245. mock_mm1_modem_modem3gpp_proxy.h
  246. mock_mm1_modem_modemcdma_proxy.cc
  247. mock_mm1_modem_modemcdma_proxy.h
  248. mock_mm1_modem_proxy.cc
  249. mock_mm1_modem_proxy.h
  250. mock_mm1_modem_simple_proxy.cc
  251. mock_mm1_modem_simple_proxy.h
  252. mock_mm1_sim_proxy.cc
  253. mock_mm1_sim_proxy.h
  254. mock_modem.cc
  255. mock_modem.h
  256. mock_modem_cdma_proxy.cc
  257. mock_modem_cdma_proxy.h
  258. mock_modem_gsm_card_proxy.cc
  259. mock_modem_gsm_card_proxy.h
  260. mock_modem_gsm_network_proxy.cc
  261. mock_modem_gsm_network_proxy.h
  262. mock_modem_info.cc
  263. mock_modem_info.h
  264. mock_modem_manager_proxy.cc
  265. mock_modem_manager_proxy.h
  266. mock_modem_proxy.cc
  267. mock_modem_proxy.h
  268. mock_modem_simple_proxy.cc
  269. mock_modem_simple_proxy.h
  270. mock_nss.cc
  271. mock_nss.h
  272. mock_openvpn_driver.cc
  273. mock_openvpn_driver.h
  274. mock_openvpn_management_server.cc
  275. mock_openvpn_management_server.h
  276. mock_portal_detector.cc
  277. mock_portal_detector.h
  278. mock_power_manager.cc
  279. mock_power_manager.h
  280. mock_power_manager_proxy.cc
  281. mock_power_manager_proxy.h
  282. mock_process_killer.cc
  283. mock_process_killer.h
  284. mock_profile.cc
  285. mock_profile.h
  286. mock_property_store.cc
  287. mock_property_store.h
  288. mock_proxy_factory.cc
  289. mock_proxy_factory.h
  290. mock_resolver.cc
  291. mock_resolver.h
  292. mock_routing_table.cc
  293. mock_routing_table.h
  294. mock_rtnl_handler.cc
  295. mock_rtnl_handler.h
  296. mock_service.cc
  297. mock_service.h
  298. mock_sockets.cc
  299. mock_sockets.h
  300. mock_store.cc
  301. mock_store.h
  302. mock_supplicant_bss_proxy.cc
  303. mock_supplicant_bss_proxy.h
  304. mock_supplicant_interface_proxy.cc
  305. mock_supplicant_interface_proxy.h
  306. mock_supplicant_process_proxy.cc
  307. mock_supplicant_process_proxy.h
  308. mock_time.cc
  309. mock_time.h
  310. mock_vpn.cc
  311. mock_vpn.h
  312. mock_vpn_driver.cc
  313. mock_vpn_driver.h
  314. mock_vpn_provider.cc
  315. mock_vpn_provider.h
  316. mock_vpn_service.cc
  317. mock_vpn_service.h
  318. mock_wifi.cc
  319. mock_wifi.h
  320. mock_wifi_service.cc
  321. mock_wifi_service.h
  322. mock_wimax.cc
  323. mock_wimax.h
  324. mock_wimax_device_proxy.cc
  325. mock_wimax_device_proxy.h
  326. mock_wimax_manager_proxy.cc
  327. mock_wimax_manager_proxy.h
  328. mock_wimax_network_proxy.cc
  329. mock_wimax_network_proxy.h
  330. mock_wimax_provider.cc
  331. mock_wimax_provider.h
  332. mock_wimax_service.cc
  333. mock_wimax_service.h
  334. modem.cc
  335. modem.h
  336. modem_1.cc
  337. modem_1_unittest.cc
  338. modem_cdma_proxy.cc
  339. modem_cdma_proxy.h
  340. modem_cdma_proxy_interface.h
  341. modem_classic.cc
  342. modem_gsm_card_proxy.cc
  343. modem_gsm_card_proxy.h
  344. modem_gsm_card_proxy_interface.h
  345. modem_gsm_network_proxy.cc
  346. modem_gsm_network_proxy.h
  347. modem_gsm_network_proxy_interface.h
  348. modem_info.cc
  349. modem_info.h
  350. modem_info_unittest.cc
  351. modem_manager.cc
  352. modem_manager.h
  353. modem_manager_proxy.cc
  354. modem_manager_proxy.h
  355. modem_manager_proxy_interface.h
  356. modem_manager_unittest.cc
  357. modem_proxy.cc
  358. modem_proxy.h
  359. modem_proxy_interface.h
  360. modem_simple_proxy.cc
  361. modem_simple_proxy.h
  362. modem_simple_proxy_interface.h
  363. modem_unittest.cc
  364. nice_mock_control.cc
  365. nice_mock_control.h
  366. nss.cc
  367. nss.h
  368. nss_unittest.cc
  369. openvpn_driver.cc
  370. openvpn_driver.h
  371. openvpn_driver_unittest.cc
  372. openvpn_management_server.cc
  373. openvpn_management_server.h
  374. openvpn_management_server_unittest.cc
  375. portal_detector.cc
  376. portal_detector.h
  377. portal_detector_unittest.cc
  378. power_manager.cc
  379. power_manager.h
  380. power_manager_proxy.cc
  381. power_manager_proxy.h
  382. power_manager_proxy_interface.h
  383. power_manager_unittest.cc
  384. process_killer.cc
  385. process_killer.h
  386. process_killer_unittest.cc
  387. profile.cc
  388. profile.h
  389. profile_dbus_adaptor.cc
  390. profile_dbus_adaptor.h
  391. profile_dbus_property_exporter.cc
  392. profile_dbus_property_exporter.h
  393. profile_dbus_property_exporter_unittest.cc
  394. profile_unittest.cc
  395. property_accessor.h
  396. property_accessor_unittest.cc
  397. property_iterator.h
  398. property_store.cc
  399. property_store.h
  400. property_store_inspector.cc
  401. property_store_inspector.h
  402. property_store_unittest.cc
  403. property_store_unittest.h
  404. provider_db_unittest.bfd
  405. proxy_factory.cc
  406. proxy_factory.h
  407. refptr_types.h
  408. resolver.cc
  409. resolver.h
  410. resolver_unittest.cc
  411. routing_table.cc
  412. routing_table.h
  413. routing_table_entry.h
  414. routing_table_unittest.cc
  415. rpc_task.cc
  416. rpc_task.h
  417. rpc_task_dbus_adaptor.cc
  418. rpc_task_dbus_adaptor.h
  419. rpc_task_unittest.cc
  420. rtnl_handler.cc
  421. rtnl_handler.h
  422. rtnl_handler_unittest.cc
  423. rtnl_listener.cc
  424. rtnl_listener.h
  425. rtnl_listener_unittest.cc
  426. rtnl_message.cc
  427. rtnl_message.h
  428. rtnl_message_unittest.cc
  429. scope_logger.cc
  430. scope_logger.h
  431. scope_logger_unittest.cc
  432. service.cc
  433. service.h
  434. service_dbus_adaptor.cc
  435. service_dbus_adaptor.h
  436. service_sorter.h
  437. service_under_test.cc
  438. service_under_test.h
  439. service_unittest.cc
  440. shill.conf
  441. shill_ares.cc
  442. shill_ares.h
  443. shill_config.cc
  444. shill_config.h
  445. shill_daemon.cc
  446. shill_daemon.h
  447. shill_main.cc
  448. shill_test_config.cc
  449. shill_test_config.h
  450. shill_time.cc
  451. shill_time.h
  452. shill_unittest.cc
  453. sockets.cc
  454. sockets.h
  455. static_ip_parameters.cc
  456. static_ip_parameters.h
  457. static_ip_parameters_unittest.cc
  458. store_interface.h
  459. supplicant_bss_proxy.cc
  460. supplicant_bss_proxy.h
  461. supplicant_bss_proxy_interface.h
  462. supplicant_interface_proxy.cc
  463. supplicant_interface_proxy.h
  464. supplicant_interface_proxy_interface.h
  465. supplicant_process_proxy.cc
  466. supplicant_process_proxy.h
  467. supplicant_process_proxy_interface.h
  468. technology.cc
  469. technology.h
  470. technology_unittest.cc
  471. TESTING
  472. testrunner.cc
  473. virtio_ethernet.cc
  474. virtio_ethernet.h
  475. vpn.cc
  476. vpn.h
  477. vpn_driver.cc
  478. vpn_driver.h
  479. vpn_driver_unittest.cc
  480. vpn_provider.cc
  481. vpn_provider.h
  482. vpn_provider_unittest.cc
  483. vpn_service.cc
  484. vpn_service.h
  485. vpn_service_unittest.cc
  486. vpn_unittest.cc
  487. wifi.cc
  488. wifi.h
  489. wifi_endpoint.cc
  490. wifi_endpoint.h
  491. wifi_endpoint_unittest.cc
  492. wifi_service.cc
  493. wifi_service.h
  494. wifi_service_unittest.cc
  495. wifi_unittest.cc
  496. wimax.cc
  497. wimax.h
  498. wimax_device_proxy.cc
  499. wimax_device_proxy.h
  500. wimax_device_proxy_interface.h
  501. wimax_manager_proxy.cc
  502. wimax_manager_proxy.h
  503. wimax_manager_proxy_interface.h
  504. wimax_network_proxy.cc
  505. wimax_network_proxy.h
  506. wimax_network_proxy_interface.h
  507. wimax_provider.cc
  508. wimax_provider.h
  509. wimax_provider_unittest.cc
  510. wimax_service.cc
  511. wimax_service.h
  512. wimax_service_unittest.cc
  513. wimax_unittest.cc
  514. wpa_supplicant.cc
  515. wpa_supplicant.h