commit | cf24a2465a3e7b5a11fa97be282f0af47aa3ef6e | [log] [tgz] |
---|---|---|
author | mukesh agrawal <quiche@chromium.org> | Mon May 21 16:46:11 2012 -0700 |
committer | Gerrit <chrome-bot@google.com> | Wed May 23 10:03:54 2012 -0700 |
tree | 4ef928409efe65490a907d312303d3a2d51202ad | |
parent | bad114bfc38ef27acab030afc7d8b0bacaf871c1 [diff] |
shill: implement heuristic for WPA/WPA2 bad-passphrase detection BUG=chromium-os:23211 TEST=new unit tests, manual (see below) Collateral changes: - alphabetize properties in Service::Load, Service::Save - clean up some comments (remove stale ones, fix typos) - minor refactoring of WiFi::HandleDisconnect, so that we don't bail early if we can't find the network to disable Manual testing: - Try connecting to a WPA network using the wrong password. Note that the password must be syntactically valid. (E.g. try "abcdefgh".) - Observe that Chrome shows the "Network Connection Error" dialog. - Dismiss dialog. /home/chronos/user/shill/shill.profile - Try connecting to a WPA network using the wrong password. Note that the password must be syntactically valid. (E.g. try "abcdefgh".) - Observe that Chrome does NOT show the "Network Connection Error" dialog. Change-Id: If8f223432c324862965729e05b20b455177ca1f5 Reviewed-on: https://gerrit.chromium.org/gerrit/23290 Reviewed-by: Gary Morain <gmorain@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org> Commit-Ready: mukesh agrawal <quiche@chromium.org>