commit | d1bd02eeff55c908723396306ec6511ce22c3f41 | [log] [tgz] |
---|---|---|
author | mukesh agrawal <quiche@chromium.org> | Fri May 24 16:03:56 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Tue May 28 13:50:23 2013 -0700 |
tree | 13daa7f19219aa1700837964c37859b0cd46c075 | |
parent | f2b4a3448a051ec9e9be3027c8e4b79928e026a2 [diff] |
shill: clean up PPP object management Previously, we were creating (and deleting) a PPP object on every call into functions of c_ppp.cc. Now, we use a LazyInstance, and retain the PPP object until PPPOnExit. Note that I've moved the AtExitManager from ppp.cc to c_ppp.cc, because the AtExitManager must now clean up the PPP object as well. BUG=chromium:242752 TEST=unit tests, manual Manual test ----------- - connect to CrOS_WPA2_Buffalo2_AG300H_2.4GHz - /usr/local/lib/flimflam/test/connect-vpn l2tpipsec-psk \ Cisco-ASA-173 172.22.22.173 \ Cisco-ASA-173 chromeos_psk \ CrOS_Password <password> - check that ppp0 has an IP address - egrep "l2tpipsec_vpn.+pppd: local" /var/log/net.log (should match) Change-Id: I7171566d30f6defb8da0f445469ee809bab3fec4 Reviewed-on: https://gerrit.chromium.org/gerrit/56664 Tested-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org>