commit | d1c7b413bf7e1f264d1acfdfb2f698413f6cf352 | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Thu Jun 11 17:51:54 2015 -0700 |
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | Sat Jun 13 17:04:34 2015 +0000 |
tree | 3034b0c896e183a908882ed561b32c9af05ad05f | |
parent | 21a567fd6ef3ec87386db9c119d411f13399fe95 [diff] |
shill: DHCPCDProxy: Ignore messages from unbound PIDs When an interface is destroyed, shill and dhcpcd race to destroy configuration. The situation that this CL resolves is one where dhcpcd still has an outstanding signal that is delivered to the DHCPCDProxy after the PID has been unbound from the DHCPProvider. This CL maintains a short set of previously unbound PIDs that can be used to dismiss messages from recently departed dhcpcd instances without triggering an error message. While here, correct the DHCPConfig unit test to use a mocked DHCPProvider instead of a real one, and move testing of the Bind and Unbind methods to the DHCPProvider unit test where it makes more sense. BUG=chromium:498908 TEST=Unit tests + "rmmod asix; modprobe asix" # Reload ethernet TEST="grep 'Unknown DHCP client PID' /var/log/messages" Change-Id: Ic55b0b2281651fd78a7e6fccb1b0fc2e7e520bcb Reviewed-on: https://chromium-review.googlesource.com/277138 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>