shill: wifi cleanups
three cleanups:
- WiFi and WiFiService: rename deferred task handlers (RealScanDone
and RealConnect) from Real<Func> to <Func>Task. this makes them
consistent with the naming in Modem.
- WiFiMainTest:
- use scoped_ptrs (rather than bare) for references to mock
proxies. this simplifies memory management, and makes WiFiMainTest
more consistent with DHCPConfigTest
- eliminate "uninteresting mock function call" messages
BUG=chromium-os:18349
TEST=FEATURES="test nostrip noclean" emerge-x86-generic shill
Change-Id: Ia4f340ab861c5a0ae44a730ca3e1a664ca03180a
Reviewed-on: http://gerrit.chromium.org/gerrit/4939
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
diff --git a/wifi_service.cc b/wifi_service.cc
index b536165..5fe88f8 100644
--- a/wifi_service.cc
+++ b/wifi_service.cc
@@ -58,7 +58,7 @@
// NB(quiche) defer handling, since dbus-c++ does not permit us to
// send an outbound request while processing an inbound one.
dispatcher_->PostTask(
- task_factory_.NewRunnableMethod(&WiFiService::RealConnect));
+ task_factory_.NewRunnableMethod(&WiFiService::ConnectTask));
}
void WiFiService::Disconnect() {
@@ -78,7 +78,7 @@
return ssid_;
}
-void WiFiService::RealConnect() {
+void WiFiService::ConnectTask() {
wifi_->ConnectTo(*this);
}