commit e4b270274cba2a1976c7be6c733bd899e009c1d1
author Darin Petkov <petkov@chromium.org> Wed May 16 13:28:50 2012 +0200
committer Gerrit <chrome-bot@google.com> Thu May 17 01:40:22 2012 -0700
tree cf8f442c382afba4a9f3409b86e7433c0ee573b2
parent c8d2d96a6bc8a0cb753a50360daf6c3d11a302ed

shill: Complete interaction between DeviceInfo and WiMaxProvider.

WiMaxProvider now creates/registers and destroys/deregisters devices
based on DeviceInfo and RPC callbacks. Also, add missing DeviceInfo
WiMax unit tests, and implement WiMaxService's GetDeviceRpcIdentifier
and GetStorageIdentifier.

BUG=chrome-os-partner:9735
TEST=unit tests

Change-Id: I9dbf8f785ef824ca5628b96a2e22ec0ef6336b97
Reviewed-on: https://gerrit.chromium.org/gerrit/22807
Commit-Ready: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>

wimax_service.cc

diff --git a/wimax_service.cc b/wimax_service.cc
index b6524ef..3d08b65 100644
--- a/wimax_service.cc
+++ b/wimax_service.cc
@@ -4,6 +4,9 @@
 
 #include "shill/wimax_service.h"
 
+#include <base/string_util.h>
+#include <chromeos/dbus/service_constants.h>
+
 #include "shill/technology.h"
 #include "shill/wimax.h"
 
@@ -17,8 +20,11 @@
                            Manager *manager,
                            const WiMaxRefPtr &wimax)
     : Service(control, dispatcher, metrics, manager, Technology::kWiMax),
-      wimax_(wimax) {
-}
+      wimax_(wimax),
+      storage_id_(
+          StringToLowerASCII(string(flimflam::kTypeWimax) +
+                             "_" +
+                             wimax_->address())) {}
 
 WiMaxService::~WiMaxService() {}
 
@@ -37,13 +43,11 @@
 }
 
 string WiMaxService::GetStorageIdentifier() const {
-  // TODO(benchan,petkov): Generate a proper storage identifier.
-  return "";
+  return storage_id_;
 }
 
 string WiMaxService::GetDeviceRpcId(Error *error) {
-  // TODO(benchan,petkov): Is this need?
-  return "";
+  return wimax_->GetRpcIdentifier();
 }
 
 }  // namespace shill