commit | 68710d73d07b5b6f2a083b6807edd43df23be17f | [log] [tgz] |
---|---|---|
author | Darin Petkov <petkov@chromium.org> | Wed Feb 13 14:22:56 2013 +0100 |
committer | ChromeBot <chrome-bot@google.com> | Thu Feb 14 07:43:32 2013 -0800 |
tree | 3b0111fde21d29a02dc03e91d956c5e832501d43 | |
parent | 40a2f868b8588df175a63227e815bc09def089a1 [diff] |
shill: vpn: Don't leak file descriptors after VPN is disconnected. Removed a misguided attempt to redirect stderr/stdout from the spawned VPN clients thus avoiding file descriptor leaks. Also, don't register default service watcher if openpvn fails to spawn. BUG=chromium-os:38879 TEST=unit tests; lsof | fgrep shill | wc before connecting to VPN and after disconnecting; tested connecting to OpenVPN and L2TP/IPSec; disable/enable WiFi while connected to corp OpenVPN, observe successful reconnect; checked syslog for messages from openvpn, l2tpipsec_vpn, pppd -- all there. Change-Id: I28bde71d7cbfcc885bb49bc2215b6bd3dc063a13 Reviewed-on: https://gerrit.chromium.org/gerrit/43170 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Darin Petkov <petkov@chromium.org>