commit f1961f836f8f6fc8afaa5b97872b45d31cd081f6
author Paul Stewart <pstew@chromium.org> Tue Sep 11 20:45:39 2012 -0700
committer Gerrit <chrome-bot@google.com> Fri Sep 14 11:56:24 2012 -0700
tree ab4653d4d7e44185031e47037f7ca1f90672715e
parent 60519993f780c5a0415a56008b5ac81a66ea16c7

shill: LinkMonitor: Apply readability-review comments

Modify LinkMonitor and those affected by it to add
changes suggested during readability review.

BUG=chromium-os:32600
TEST=Unit tests

Change-Id: Ie48ac6d6ea1727207042fe5bf1519875b0673501
Reviewed-on: https://gerrit.chromium.org/gerrit/33047
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>

metrics.cc

diff --git a/metrics.cc b/metrics.cc
index f9a010f..1eee4b7 100644
--- a/metrics.cc
+++ b/metrics.cc
@@ -109,21 +109,21 @@
     "Network.Shill.%s.LinkMonitorFailure";
 const char Metrics::kMetricLinkMonitorResponseTimeSample[] =
     "Network.Shill.%s.LinkMonitorResponseTimeSample";
-const unsigned int Metrics::kMetricLinkMonitorResponseTimeSampleMin = 0;
-const unsigned int Metrics::kMetricLinkMonitorResponseTimeSampleMax =
+const int Metrics::kMetricLinkMonitorResponseTimeSampleMin = 0;
+const int Metrics::kMetricLinkMonitorResponseTimeSampleMax =
     LinkMonitor::kTestPeriodMilliseconds;
 const int Metrics::kMetricLinkMonitorResponseTimeSampleNumBuckets = 50;
 const char Metrics::kMetricLinkMonitorSecondsToFailure[] =
     "Network.Shill.%s.LinkMonitorSecondsToFailure";
-const unsigned int Metrics::kMetricLinkMonitorSecondsToFailureMin = 0;
-const unsigned int Metrics::kMetricLinkMonitorSecondsToFailureMax = 7200;
+const int Metrics::kMetricLinkMonitorSecondsToFailureMin = 0;
+const int Metrics::kMetricLinkMonitorSecondsToFailureMax = 7200;
 const int Metrics::kMetricLinkMonitorSecondsToFailureNumBuckets = 50;
 const char Metrics::kMetricLinkMonitorBroadcastErrorsAtFailure[] =
     "Network.Shill.%s.LinkMonitorBroadcastErrorsAtFailure";
 const char Metrics::kMetricLinkMonitorUnicastErrorsAtFailure[] =
     "Network.Shill.%s.LinkMonitorUnicastErrorsAtFailure";
-const unsigned int Metrics::kMetricLinkMonitorErrorCountMin = 0;
-const unsigned int Metrics::kMetricLinkMonitorErrorCountMax =
+const int Metrics::kMetricLinkMonitorErrorCountMin = 0;
+const int Metrics::kMetricLinkMonitorErrorCountMax =
     LinkMonitor::kFailureThreshold;
 const int Metrics::kMetricLinkMonitorErrorCountNumBuckets =
     LinkMonitor::kFailureThreshold + 1;
@@ -419,9 +419,9 @@
 void Metrics::NotifyLinkMonitorFailure(
     Technology::Identifier technology,
     LinkMonitorFailure failure,
-    unsigned int seconds_to_failure,
-    unsigned int broadcast_error_count,
-    unsigned int unicast_error_count) {
+    int seconds_to_failure,
+    int broadcast_error_count,
+    int unicast_error_count) {
   string histogram = GetFullMetricName(kMetricLinkMonitorFailure,
                                        technology);
   SendEnumToUMA(histogram, failure, kLinkMonitorFailureMax);
@@ -456,7 +456,7 @@
 
 void Metrics::NotifyLinkMonitorResponseTimeSampleAdded(
     Technology::Identifier technology,
-    unsigned int response_time_milliseconds) {
+    int response_time_milliseconds) {
   string histogram = GetFullMetricName(kMetricLinkMonitorResponseTimeSample,
                                        technology);
   SendToUMA(histogram,