commit f1961f836f8f6fc8afaa5b97872b45d31cd081f6
author Paul Stewart <pstew@chromium.org> Tue Sep 11 20:45:39 2012 -0700
committer Gerrit <chrome-bot@google.com> Fri Sep 14 11:56:24 2012 -0700
tree ab4653d4d7e44185031e47037f7ca1f90672715e
parent 60519993f780c5a0415a56008b5ac81a66ea16c7

shill: LinkMonitor: Apply readability-review comments

Modify LinkMonitor and those affected by it to add
changes suggested during readability review.

BUG=chromium-os:32600
TEST=Unit tests

Change-Id: Ie48ac6d6ea1727207042fe5bf1519875b0673501
Reviewed-on: https://gerrit.chromium.org/gerrit/33047
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>

metrics.h

diff --git a/metrics.h b/metrics.h
index 16067e0..5383403 100644
--- a/metrics.h
+++ b/metrics.h
@@ -197,17 +197,17 @@
   // LinkMonitor statistics.
   static const char kMetricLinkMonitorFailure[];
   static const char kMetricLinkMonitorResponseTimeSample[];
-  static const unsigned int kMetricLinkMonitorResponseTimeSampleMin;
-  static const unsigned int kMetricLinkMonitorResponseTimeSampleMax;
+  static const int kMetricLinkMonitorResponseTimeSampleMin;
+  static const int kMetricLinkMonitorResponseTimeSampleMax;
   static const int kMetricLinkMonitorResponseTimeSampleNumBuckets;
   static const char kMetricLinkMonitorSecondsToFailure[];
-  static const unsigned int kMetricLinkMonitorSecondsToFailureMin;
-  static const unsigned int kMetricLinkMonitorSecondsToFailureMax;
+  static const int kMetricLinkMonitorSecondsToFailureMin;
+  static const int kMetricLinkMonitorSecondsToFailureMax;
   static const int kMetricLinkMonitorSecondsToFailureNumBuckets;
   static const char kMetricLinkMonitorBroadcastErrorsAtFailure[];
   static const char kMetricLinkMonitorUnicastErrorsAtFailure[];
-  static const unsigned int kMetricLinkMonitorErrorCountMin;
-  static const unsigned int kMetricLinkMonitorErrorCountMax;
+  static const int kMetricLinkMonitorErrorCountMin;
+  static const int kMetricLinkMonitorErrorCountMax;
   static const int kMetricLinkMonitorErrorCountNumBuckets;
 
   static const char kMetricLinkClientDisconnectReason[];
@@ -268,15 +268,15 @@
   void NotifyLinkMonitorFailure(
       Technology::Identifier technology,
       LinkMonitorFailure failure,
-      unsigned int seconds_to_failure,
-      unsigned int broadcast_error_count,
-      unsigned int unicast_error_count);
+      int seconds_to_failure,
+      int broadcast_error_count,
+      int unicast_error_count);
 
   // Notifies this object that LinkMonitor has added a response time sample
   // for |connection| with a value of |response_time_milliseconds|.
   void NotifyLinkMonitorResponseTimeSampleAdded(
       Technology::Identifier technology,
-      unsigned int response_time_milliseconds);
+      int response_time_milliseconds);
 
   // Notifies this object of WiFi disconnect.
   void Notify80211Disconnect(WiFiDisconnectByWhom by_whom,